Repository navigation
Repin install-whitaker to 5a99aed7 (whitaker-installer 0.2.11) - #160
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates the Whitaker installation action to a verified commit whose installer builds the Dylint driver from a stable, verified Clippy snapshot, preventing cold-build failures caused by upstream Dylint 6.0.1 referencing the removed Clippy master branch; the corresponding workflow contract pin is updated to keep CI enforcement aligned. Flow diagram for the updated Whitaker pin enforcementflowchart TD
Workflow[CI workflow pin] --> Contract[INSTALL_PIN contract]
Contract --> Match{Pins match?}
Match -->|Yes| Install[Install Whitaker]
Match -->|No| Fail[Contract check fails]
Install --> Lint[Run lint lane]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary
Validation
WalkthroughPin the CI workflow’s ChangesWhitaker action pin
Possibly related issues
Possibly related PRs
Priority: Change: Bug fix Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Developer Documentation |  |
Update the developer guide before merging. The pull request changes the CI Whitaker provisioning tool from shared action pin 6dea5677... to 5a99aed7..., which selects whitaker-installer 0.2.11 a… |
Update docs/developers-guide.md in the Whitaker setup section. Record the approved shared action pin or its selected whitaker-installer version, explain that 0.2.11 uses a verified Clippy snapshot because Dylint 6.0.1 cannot clone the r… |
-
Check name Status Explanation Title check The title accurately describes the main change: repinning the Whitaker installation action to the specified commit and installer version. No GitHub issue number is required because the description doe… Description check The description directly explains the Whitaker action repin, the updated workflow contract, the build failure, and the validation gate. It is clearly related to the changeset. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Testing (Overall) Pass the testing check. The existing workflow contract test loads the actual ci.ymland asserts the installer uses the exact approved full SHA throughINSTALL_PIN. Its mutation case replaces the p…User-Facing Documentation Pass the documentation check. The diff changes only the CI Whitaker action pin and its workflow contract pin. It does not change a user-facing application interface or documented usage. The existing u… Module-Level Documentation The pull request changes a workflow YAML file and one existing Python module. tests/workflow_contracts/whitaker_contracts.pyhas the module docstring `"""Read and validate Statelet's binding Whitake…Testing (Unit And Behavioural) The change updates only the external Whitaker action pin and its workflow-contract expectation. Existing tests exercise the relevant boundary: whitaker_gate_test.pyloads.github/workflows/ci.yml,…Testing (Property / Proof) PASS: The pull request changes one GitHub Actions SHA pin and the matching INSTALL_PINconstant. It does not introduce a new invariant over a range of inputs, states, orderings, or transitions. It i…Testing (Compile-Time / Ui) Pass this check because the pull request changes only a GitHub Actions pin in .github/workflows/ci.ymland the matching Python contract constant intests/workflow_contracts/whitaker_contracts.py. …Unit Architecture Pass. The pull request changes only the pinned revision of the existing install-whitakerworkflow action and the matchingINSTALL_PINtest constant. It does not add or alter query units, command i…Domain Architecture The pull request changes only the GitHub Actions Whitaker pin and its workflow contract. It does not change domain logic, adapters, repositories, transport code, persistence code, or framework boundar… Observability Pass this check. The pull request changes only the pinned Whitaker GitHub Action revision and its workflow contract pin. It changes CI tool provisioning, not production application behaviour or a prod… Full details: Title check
-
Explanation
The title accurately describes the main change: repinning the Whitaker installation action to the specified commit and installer version. No GitHub issue number is required because the description does not reference a GitHub issue in the required format.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Full details: Testing (Overall)
-
Explanation
Pass the testing check. The existing workflow contract test loads the actual
ci.ymland asserts the installer uses the exact approved full SHA throughINSTALL_PIN. Its mutation case replaces the pin with an incorrect value and requires the contract to reject it. The PR updatesINSTALL_PINto match the changed workflow pin, so the test guards the introduced configuration behaviour. The test suite runs throughmake test-workflow-contracts. Do not require a test of the third-party Whitaker installer itself.
Full details: User-Facing Documentation
-
Explanation
Pass the documentation check. The diff changes only the CI Whitaker action pin and its workflow contract pin. It does not change a user-facing application interface or documented usage. The existing user guide already identifies Whitaker as a lint prerequisite and links to the developer installation guidance.
Full details: Module-Level Documentation
-
Explanation
The pull request changes a workflow YAML file and one existing Python module.
tests/workflow_contracts/whitaker_contracts.pyhas the module docstring"""Read and validate Statelet's binding Whitaker consumer contracts."""in both the base and head revisions. The docstring states the module's purpose and function, and identifies its Whitaker consumer-contract relationship. The workflow file is not a module. No documentation failure is introduced.
Full details: Testing (Unit And Behavioural)
-
Explanation
The change updates only the external Whitaker action pin and its workflow-contract expectation. Existing tests exercise the relevant boundary:
whitaker_gate_test.pyloads.github/workflows/ci.yml, requires the exact full SHA, checks installer ordering and inputs, and rejects a wrong pin. The CI workflow then runs the pinned installer beforemake lint, whilewhitaker_failure_propagation_test.pycovers the local Make failure path. No new unit test is required for this pin-only change.
Full details: Testing (Property / Proof)
-
Explanation
PASS: The pull request changes one GitHub Actions SHA pin and the matching
INSTALL_PINconstant. It does not introduce a new invariant over a range of inputs, states, orderings, or transitions. It introduces no lemma or proof assumption. The existing Whitaker contract uses a small parameterized mutation table for relevant workflow failures, which fits the stated testing guidance better than a property test.
Full details: Testing (Compile-Time / Ui)
-
Explanation
Pass this check because the pull request changes only a GitHub Actions pin in
.github/workflows/ci.ymland the matching Python contract constant intests/workflow_contracts/whitaker_contracts.py. It introduces no Rust or TypeScript compile-time behaviour and no text, structured, or UI-adjacent output that requires snapshot coverage.
Full details: Unit Architecture
-
Explanation
Pass. The pull request changes only the pinned revision of the existing
install-whitakerworkflow action and the matchingINSTALL_PINtest constant. It does not add or alter query units, command interfaces, dependency boundaries, fallible APIs, or side-effect handling. The existing installer remains an explicit workflow command beforemake lint, andcranelift: trueremains unchanged.
Full details: Domain Architecture
-
Explanation
The pull request changes only the GitHub Actions Whitaker pin and its workflow contract. It does not change domain logic, adapters, repositories, transport code, persistence code, or framework boundaries. The workflow keeps the existing
cranelift: trueinput, and the contract matches the new immutable pin.
Full details: Observability
-
Explanation
Pass this check. The pull request changes only the pinned Whitaker GitHub Action revision and its workflow contract pin. It changes CI tool provisioning, not production application behaviour or a production service boundary. The workflow retains named
Install WhitakerandLintsteps; GitHub Actions captures their command output and failure status for diagnosis. No new production failure mode requires logs, metrics, tracing, or alerts.
-
Full details: Developer Documentation
-
Explanation
Update the developer guide before merging. The pull request changes the CI Whitaker provisioning tool from shared action pin
6dea5677...to5a99aed7..., which selectswhitaker-installer 0.2.11and changes cold driver-build behaviour.docs/developers-guide.md:41-46documents only the generic action and local prerequisites. It does not document the selected installer version or the reason for the required repin. No documentation files changed in the pull request.Resolution
Update
docs/developers-guide.mdin the Whitaker setup section. Record the approved shared action pin or its selectedwhitaker-installerversion, explain that 0.2.11 uses a verified Clippy snapshot because Dylint 6.0.1 cannot clone the removedmasterbranch, and state the expected cache-restored driver rebuild. Keep any relevant historical execution record clearly marked as historical.
Pin the action, match the test,
Keep the Cranelift input at rest.
One revision guides the build,
The workflow’s contract is fulfilled.
Whitaker follows the chosen trail.
Comment @coderabbitai help to get the list of available commands.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Part of DF12-89
Repins
leynos/shared-actions/.github/actions/install-whitakerto5a99aed78ce68dcebd3052b75c31e6f173162b1e(shared-actions #651, approved as a root by concordat QG-002, leynos/concordat#331). The action then defaults to whitaker-installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot: upstream Dylint 6.0.1 clones Clippy'smaster, which no longer exists, so every cold Whitaker driver build fails.Also
INSTALL_PINintests/workflow_contracts/whitaker_contracts.py.Other Whitaker paths
No bare
cargo dylint,cargo binstall whitakeror hand-rolled installer outside the action and thewhitakerwrapper.Notes
A cache-restored driver rebuilds once (about a minute); that is expected. Gate: CI green on the lint lane at the head, with the lint job's log read for Whitaker's diagnostics.
Summary by Sourcery
Repin the Whitaker installation action to restore reliable CI lint-driver builds.
Bug Fixes:
Enhancements:
CI: