Repository navigation
Repin install-whitaker to the 0.2.11 revision - #211
Conversation
Pin install-whitaker to shared-actions 5a99aed78ce68dcebd3052b75c31e6f173162b1e, which defaults the installer to 0.2.11 and builds the Dylint driver from a verified Clippy snapshot. Upstream Dylint 6.0.1 clones Clippy's deleted master branch, so every cold driver build failed. Any explicit installer-version is set to 0.2.11.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update Whitaker action revision .github/workflows/ci.yml |
The Whitaker Dylint suite installation step now uses revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e instead of 8e6a325765ba382691d1b1c65fcccf1fc1d1b00c. |
Possibly related issues
- leynos/whitaker#530: This issue calls for downstream adoption of the released Whitaker installer through the shared action; this change updates the action revision.
Possibly related PRs
- leynos/msgspec-crockford#54: This PR pins the same shared action revision.
- leynos/corbusier#249: This PR updates the
install-whitakeraction to the same revision. - leynos/malarky#67: This PR applies the same
install-whitakerpin.
Suggested labels: Issue
Suggested reviewers: codescene-access
Priority:
Change: Bug fix
Merge Risk: 
45e26
-
The pin update preserves the existing Whitaker installation and lint workflow.
Pre-merge checks: 
-
Check name Status Explanation Resolution Developer Documentation The pull request changes a CI build tool pin: .github/workflows/ci.yml:42changes theinstall-whitakeraction revision. The action supplies the Whitaker/Dylint tooling used bymake lintat `Make…Update docs/developers-guide.mdwith the Whitaker/Dylint lint-tool requirement, including thewhitaker-installerversion0.2.11, how CI installs it, and how developers can satisfy themake lintprerequisite. Keep any architecture or…-
Check name Status Explanation Title check The title accurately describes the workflow change: repinning the install-whitaker action to revision 0.2.11. No roadmap or GitHub issue reference is required by the supplied context. Description check The description directly explains the pin update, target revision, installer version, and reason for the change. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Testing (Overall) PASS: The pull request changes only the pinned revision of the external leynos/shared-actions/.github/actions/install-whitakeraction in.github/workflows/ci.yml. It adds no repository functionali…User-Facing Documentation Pass this check. The pull request changes only the pinned revision of the CI install-whitakeraction. It changes the lint tooling used by CI, not user-facing functionality or behaviour. No users-gui…Module-Level Documentation The check is not applicable to this pull request. The authoritative diff changes only the pinned revision of leynos/shared-actions/.github/actions/install-whitakerin.github/workflows/ci.yml; it …Testing (Unit And Behavioural) PASS — The pull request changes only the pinned revision of the existing install-whitakerGitHub Action in.github/workflows/ci.yml. It does not add or change local behaviour, error paths, invaria…Testing (Property / Proof) Pass. The pull request changes one GitHub Actions pin in .github/workflows/ci.ymlfrom one immutableinstall-whitakerrevision to another. It introduces no code invariant over inputs, states, orde…Testing (Compile-Time / Ui) PASS — The pull request changes only the pinned revision of the install-whitakerGitHub Action in.github/workflows/ci.yml. It introduces no Rust or TypeScript compile-time behaviour and no text, …Unit Architecture Pass the Unit Architecture check. The pull request changes one workflow action reference only. It does not add or modify queries, commands, fallible APIs, dependency boundaries, state handling, or tes… Domain Architecture The pull request changes only the pinned revision of the install-whitakerGitHub Action in.github/workflows/ci.yml. It does not change domain logic, adapters, repositories, commands, or infrastru…Observability Pass the observability check. The pull request changes only the pinned revision of the CI-only install-whitakeraction in.github/workflows/ci.yml; it does not alter production code or production …Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Testing (Overall)
-
Explanation
PASS: The pull request changes only the pinned revision of the external
leynos/shared-actions/.github/actions/install-whitakeraction in.github/workflows/ci.yml. It adds no repository functionality or local behavioural code. The workflow still runsmake lintand the existing workflow-contract tests. The check explicitly does not require tests to verify that a third-party tool works as advertised, so no new substantive test is required for this pin-only change.
Full details: User-Facing Documentation
-
Explanation
Pass this check. The pull request changes only the pinned revision of the CI
install-whitakeraction. It changes the lint tooling used by CI, not user-facing functionality or behaviour. No users-guide update is required.
Full details: Module-Level Documentation
-
Explanation
The check is not applicable to this pull request. The authoritative diff changes only the pinned revision of
leynos/shared-actions/.github/actions/install-whitakerin.github/workflows/ci.yml; it adds or changes no module.
Full details: Testing (Unit And Behavioural)
-
Explanation
PASS — The pull request changes only the pinned revision of the existing
install-whitakerGitHub Action in.github/workflows/ci.yml. It does not add or change local behaviour, error paths, invariants, or command-line logic. The existing workflow still exercises the integration boundary by installing Whitaker and runningmake lint; the existing workflow contract tests also verify that the lint gate runs for pull requests. No additional unit or behavioural test is required for this pin-only change.
Full details: Testing (Property / Proof)
-
Explanation
Pass. The pull request changes one GitHub Actions pin in
.github/workflows/ci.ymlfrom one immutableinstall-whitakerrevision to another. It introduces no code invariant over inputs, states, orderings, or transitions, and it introduces no lemma or proof assumption. A property test or exhaustive proof is therefore not required.
Full details: Testing (Compile-Time / Ui)
-
Explanation
PASS — The pull request changes only the pinned revision of the
install-whitakerGitHub Action in.github/workflows/ci.yml. It introduces no Rust or TypeScript compile-time behaviour and no text, structured, or UI output. Trybuild and snapshot tests are therefore not applicable.
Full details: Unit Architecture
-
Explanation
Pass the Unit Architecture check. The pull request changes one workflow action reference only. It does not add or modify queries, commands, fallible APIs, dependency boundaries, state handling, or tests. The Whitaker invocation and all repository-side references remain unchanged.
Full details: Domain Architecture
-
Explanation
The pull request changes only the pinned revision of the
install-whitakerGitHub Action in.github/workflows/ci.yml. It does not change domain logic, adapters, repositories, commands, or infrastructure boundaries in the application code. The custom check has no failure condition for this pin-only workflow change.
Full details: Observability
-
Explanation
Pass the observability check. The pull request changes only the pinned revision of the CI-only
install-whitakeraction in.github/workflows/ci.yml; it does not alter production code or production telemetry. The named install step and the followingmake lintstep remain in place, so action and lint failures stay visible in the workflow logs. No new service, queue, storage, network, or runtime failure mode requires metrics, tracing, or alerts.
-
Full details: Developer Documentation
-
Explanation
The pull request changes a CI build tool pin:
.github/workflows/ci.yml:42changes theinstall-whitakeraction revision. The action supplies the Whitaker/Dylint tooling used bymake lintatMakefile:66-68.docs/developers-guide.mddocuments other CI tooling but contains no Whitaker, Dylint, or installer-version guidance. The pull request changes tooling without updating the developer guide.Resolution
Update
docs/developers-guide.mdwith the Whitaker/Dylint lint-tool requirement, including thewhitaker-installerversion0.2.11, how CI installs it, and how developers can satisfy themake lintprerequisite. Keep any architecture or ADR documents unchanged because this diff introduces no architectural change.
-
Pin the action, fix the track
Let Whitaker take the new path
Dylint starts with steady feet
CI keeps its familiar beat
One revision, neatly set
Comment @coderabbitai help to get the list of available commands.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CI workflow to use the approved shared-actions revision that installs whitaker-installer 0.2.11, addressing cold-build failures caused by Dylint 6.0.1 targeting Clippy’s deleted master branch. Flow diagram for the updated Whitaker CI lint setupflowchart LR
CI[CI workflow] --> Install[install-whitaker shared action]
Install --> Version[whitaker-installer 0.2.11]
Version --> Driver[Verified Clippy snapshot]
Driver --> Lint[make lint]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Part of DF12-89
Repins
leynos/shared-actions/.github/actions/install-whitakerto5a99aed78ce68dcebd3052b75c31e6f173162b1e(shared-actions #651, approved by concordat #331). That revision defaults whitaker-installer to 0.2.11, which builds the Dylint driver from a verified Clippy snapshot; upstream Dylint 6.0.1 clones Clippy's deletedmasterbranch, so every cold Whitaker driver build was failing and the lint lane was red.installer-version/WHITAKER_INSTALLER_VERSIONis set to0.2.11.Summary by Sourcery
Restore the CI lint lane by repinning the Whitaker installation action to the verified revision.
Bug Fixes:
CI: