Repository navigation
Pin mdtablefix to 0.6.1 - #533
Conversation
0.6.1 fixes the 0.6.0 bugs that changed Markdown content: --wrap breaking text with no whitespace, Setext headings rewritten as rules, and --renumber changing a list's start. make check-fmt passes unchanged on main with 0.6.1.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis mechanical CI-only change updates mdtablefix from 0.6.0 to 0.6.1, preserving the formatter configuration while adopting fixes for regressions that could alter Markdown content; validation reports no required formatting changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Pin WalkthroughThe CI workflow now requests mdtablefix version 0.6.1 instead of 0.6.0. ChangesCI tool version update
Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to The workflow requests mdtablefix 0.6.1, reported to fix the formatting regressions, and the supplied installer evidence indicates stale cached versions will not be silently reused. No concrete merge blocker is evident; normal CI checks remain appropriate. 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
Full details: Developer DocumentationExplanation The pull request changes a CI tooling requirement by pinning Resolution Update
A version steps ahead Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b369daf4c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: leynos/shared-actions/.github/actions/install-mdtablefix@6dea5677a84fec60ca51b07202570e3af12ffdb4 | ||
| with: | ||
| version: "0.6.0" | ||
| version: "0.6.1" |
There was a problem hiding this comment.
When the main-branch tool cache was populated with 0.6.0, this bump leaves TOOLS_CACHE_KEY unchanged because the TOOL_PINS block at lines 117–128 omits mdtablefix, even though the archive includes the executable directories. Save global tools is then skipped on the exact hit at lines 624–646, so the installer must replace the restored 0.6.0 on every run and the corrected binary is never cached. GitHub documents that an existing cache cannot be updated and a new key is required; add this version to the inputs used for tools_hash (or otherwise change the key) so warm runs can retain 0.6.1.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Moves the mdtablefix pin from 0.6.0 to 0.6.1 in:
.github/workflows/ci.yml0.6.1 (29 September) fixes the 0.6.0 bugs that changed Markdown content:
--wrapbreaking text with no whitespace, Setext headings turned into rules, and--renumberchanging a list's start. Statements that 0.6.0 is the first release with--checkand--gitstay, because they are still true.Measurement: on a clean checkout of main at a449b87, mdtablefix 0.6.1 with the repository's
make check-fmtcommand (mdtablefix --check --git --include-untracked --wrap --renumber --breaks --ellipsis --fences) reports: "123 files left unchanged.", exit 0. No Markdown reformat is needed.This is a mechanical pin-only repin, so it merges on green at the exact head without a CodeRabbit review.
Overlap: open PRs touching the same files: #526 (.github/workflows/ci.yml ) #161 (.github/workflows/ci.yml ) #3 (.github/workflows/ci.yml ) #2 (.github/workflows/ci.yml ). I have not touched them.
Summary by Sourcery
Pin the CI Markdown formatting check to mdtablefix 0.6.1.
Bug Fixes:
CI: