Skip to content

Group leynos/shared-actions bumps into one Dependabot PR - #750

Merged
leynos merged 2 commits into
mainfrom
dependabot-shared-actions-group
Oct 9, 2026
Merged

leynos merged 2 commits into
mainfrom
dependabot-shared-actions-group

Conversation

@leynos

@leynos leynos commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Dependabot opens one pull request per pinned leynos/shared-actions action or
reusable workflow. A bump of such a pin moves one commit SHA to another, which
has no semver level, so the github-actions group (limited to minor and
patch) never takes it. Each bump therefore arrives alone.

This adds a shared-actions group with the pattern leynos/shared-actions* and
no update-types, placed ahead of the existing group because Dependabot uses
the first group that matches. All shared-actions pin bumps now arrive in one
daily pull request. Third-party actions do not match the pattern, so their
majors stay individual pull requests and their minor and patch bumps still use
the existing group. Nothing else in the file changes.

Validation

  • yamllint reports no finding that the base file did not already have.
  • Where the shared auto-merge workflow is used, it selects pull requests by the
    dependencies label, which a grouped pull request still carries, so grouping
    does not change eligibility.
  • Nothing in the repository parses .github/dependabot.yml, so this is a
    config-only change.

End-to-end evidence

The pilot on leynos/lag-complexity proves the grouping live: before the change that repository had five separate shared-actions pull requests open at once; after it merged, Dependabot closed the stale singles and opened one grouped pull request, "Bump the shared-actions group with 4 updates" (leynos/lag-complexity#154), which merged. This repository has had 0 separate shared-actions bump pull requests merged since 5 October.

Overlap

Open pull request the open drafts #650 and #709 are old agent drafts that also edit .github/dependabot.yml. This change does not touch it; whichever merges second rebases.

bincode 3 ignore

This repository depends on bincode, and bincode 3.0.0 is a compile_error!
stub, so Dependabot's bump to it cannot build (mxd #572 was closed for this
reason). A second commit adds ignore: bincode >= 3 to the cargo entry. It is a
dependabot.yml-only change and shares this pull request.

Summary by Sourcery

Configure Dependabot to consolidate shared-actions updates and avoid proposing unusable bincode 3 upgrades.

Enhancements:

  • Group Dependabot updates for leynos/shared-actions into a single daily pull request while preserving existing third-party action grouping behavior.

Chores:

  • Ignore unusable bincode versions starting at 3.0.0 in Cargo dependency updates.

leynos added 2 commits October 9, 2026 00:17
A bump of a leynos/shared-actions pin moves one commit SHA to another, and
a SHA-to-SHA update has no semver level. The github-actions catch-all is
limited to minor and patch, so it never took these updates and each pinned
action or reusable workflow arrived as its own pull request. Add a
`shared-actions` group with no update-types ahead of the catch-all, because
Dependabot uses the first group that matches. Third-party action majors do
not match its pattern and stay individual.
bincode 3.0.0 is a `compile_error!` stub, so a version bump to it can never
build and only produces a failing pull request. Ignore versions at or above 3
for the cargo entry until a usable release exists.
@sourcery-ai

sourcery-ai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 6 days and 21 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T23:19:23.886147Z 3cd638e PR opened
🔒 Security Review ✅ Completed 2026-10-08T23:20:32.159093Z 3cd638e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sourcery-ai

sourcery-ai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Dependabot configuration so shared-actions SHA bumps arrive together in one daily pull request, while preserving existing third-party action behavior, and ignores unusable bincode 3 releases.

Flow diagram for Dependabot grouping and filtering

flowchart TD
    D[Dependabot update] --> M{Matches leynos/shared-actions*}
    M -->|Yes| S[shared-actions group]
    M -->|No| G[github-actions group]
    G --> T{Update is minor or patch}
    T -->|Yes| G
    T -->|No| I[Individual pull request]
    S --> P[One daily grouped pull request]
    C[Cargo update] --> B{bincode version >= 3}
    B -->|Yes| X[Ignore update]
    B -->|No| U[Normal Cargo update handling]
Loading

File-Level Changes

Change Details Files
Adds a dedicated Dependabot group for all pinned leynos/shared-actions actions and reusable workflows.
  • Matches leynos/shared-actions* dependencies.
  • Places the group before the existing GitHub Actions group so it takes precedence.
  • Leaves third-party action grouping and major-update behavior unchanged.
.github/dependabot.yml
Prevents unusable bincode major-version updates from being proposed by Dependabot.
  • Ignores bincode versions >= 3 in the Cargo configuration.
  • Documents that the ignore can be removed once a usable bincode 3 release exists.
.github/dependabot.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: dfdc8174-c8ea-4d5b-a536-8f26fd0c2709
📥 Commits

Reviewing files that changed from the base of the PR and between 5df9a7e and 3cd638e.

📒 Files selected for processing (1)
  • .github/dependabot.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Summary

  • Add a shared-actions Dependabot group for leynos/shared-actions* updates. Keep it separate from the existing GitHub Actions group, which still groups minor and patch updates.
  • Ignore bincode versions >= 3 because the configuration comments identify bincode 3.0.0 as a compile_error! stub.

Walkthrough

Dependabot now groups updates for leynos/shared-actions* and ignores Cargo updates for bincode versions >= 3.

Changes

Dependabot update rules

Layer / File(s) Summary
Group actions and constrain Cargo updates
.github/dependabot.yml
Group matching shared actions in one update group. Ignore bincode versions >= 3; the configuration comments describe the current release constraint and when to remove the rule.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to 3cd63

The changes narrowly group the named shared-action updates and exclude bincode versions 3 and later. No actionable merge-blocking risk is established.


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Testing (Unit And Behavioural) Error The change alters the externally observable Dependabot workflow, but it adds no behavioural or end-to-end test. The diff changes only .github/dependabot.yml; existing `tests/workflow_contracts/share… Add a CI integration test at the Dependabot boundary. Verify that leynos/shared-actions* matches the first group, that third-party action updates retain the existing grouping rules, and that bincode versions >= 3 are ignored. Use a su…
✅ Passed checks (14 passed)
Check name Status Explanation
Title check Passed The title accurately identifies the main change: grouping leynos/shared-actions Dependabot updates. It does not mention the secondary bincode ignore, but the title remains sufficiently specific and re…
Description check Passed The description directly explains both configuration changes, their purpose, validation, and supporting evidence.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) Passed PASS. The pull request changes only .github/dependabot.yml: it adds a Dependabot group for leynos/shared-actions* and an ignore rule for bincode >= 3. No repository code or repository-owned conf…
User-Facing Documentation Passed PASS: The pull request changes only .github/dependabot.yml. It groups leynos/shared-actions updates and ignores unusable bincode 3 releases (lines 7–9 and 36–40). These changes affect maintainer…
Developer Documentation Passed Pass. The pull request changes only .github/dependabot.yml. It changes Dependabot grouping for leynos/shared-actions pins and ignores unusable bincode >= 3 releases. It introduces no internal AP…
Module-Level Documentation Passed PASS — The pull request changes only .github/dependabot.yml. It adds Dependabot grouping and ignore rules, not a source module. Therefore, the module-level documentation requirement is not applicabl…
Testing (Property / Proof) Passed The pull request changes only .github/dependabot.yml. It adds Dependabot grouping and an ignore rule; it does not introduce executable logic, a state-transition invariant, a lemma, or a proof assump…
Testing (Compile-Time / Ui) Passed PASS — The pull request changes only .github/dependabot.yml. It adds Dependabot grouping and an ignore rule; it does not introduce Rust or TypeScript compile-time behaviour, text output, structured …
Unit Architecture Passed PASS: The pull request changes only .github/dependabot.yml (lines 7-9 and 36-40). It adds Dependabot grouping for leynos/shared-actions* and ignores bincode >= 3. It does not add or change appli…
Domain Architecture Passed The pull request changes only .github/dependabot.yml. It adds Dependabot grouping and an ignored Cargo version range. It does not change domain code, domain interfaces, commands, repositories, adapt…
Observability Passed Pass. The pull request changes only .github/dependabot.yml. It changes Dependabot pull-request grouping and ignores bincode versions >= 3; it does not change production runtime behaviour or intr…
Full details: Testing (Unit And Behavioural)

Explanation

The change alters the externally observable Dependabot workflow, but it adds no behavioural or end-to-end test. The diff changes only .github/dependabot.yml; existing tests/workflow_contracts/shared_actions_test.py validates workflow SHA usage and does not exercise Dependabot grouping or ignore rules. The live pilot described in the PR is not a regression test in this repository.

Resolution

Add a CI integration test at the Dependabot boundary. Verify that leynos/shared-actions* matches the first group, that third-party action updates retain the existing grouping rules, and that bincode versions >= 3 are ignored. Use a supported Dependabot configuration validator or dry-run fixture if a live Dependabot run is not available.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Group shared actions as updates arrive
Keep later bincode versions at bay
Leave a note for the rule’s end
Let Dependabot check the rest
Keep the config neat and clear

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@leynos
leynos merged commit 88278b4 into main Oct 9, 2026
10 of 11 checks passed
@leynos
leynos deleted the dependabot-shared-actions-group branch October 9, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant