Repository navigation
Disable incremental compilation and dev debug data - #791
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Summary
Validation
WalkthroughSet Cargo development builds to disable incremental compilation and debug information, and enable the unstable ChangesCargo development builds
Possibly related issues
Suggested labels: Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Testing (Overall) |  |
The pull request changes development build behaviour in Cargo.toml:273-274 and .cargo/config.toml:30-31, but it adds no tests. The existing make test target tests repository functionality, not b… |
Add a CI-enforced, substantive build-footprint test for the pinned nightly. Build in a fresh target directory and assert the required incremental, debug-info, and embedded-metadata properties, or run the rust-dev-build-footprint concordat… |
| Testing (Unit And Behavioural) | |
The pull request changes the externally observable development-build workflow, but it adds no automated test. The diff changes only .cargo/config.toml and Cargo.toml; it adds `no-embed-metadata = … |
Add an automated integration or end-to-end build test. Run the pinned Cargo toolchain with a clean target directory, verify that the development profile disables incremental compilation and debug information, and verify that embedded metada… |
| Developer Documentation |  |
The pull request changes the development build standard in Cargo.toml ([profile.dev], incremental = false, debug = 0) and .cargo/config.toml (no-embed-metadata = true). The changed-file di… |
Update docs/developers-guide.md in the Development builds section. Document that development builds disable incremental compilation and debug information, and that Cargo uses [unstable] no-embed-metadata = true with the pinned nightly t… |
-
Check name Status Explanation Title check Pass the title. It accurately summarises the primary change: disabling incremental compilation and development debug data. No roadmap number or GitHub issue number is required by the provided context. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. User-Facing Documentation Pass. The pull request changes only development build settings: Cargo.tomldisables incremental compilation and debug data in[profile.dev], and.cargo/config.tomldisables embedded metadata. Th…Module-Level Documentation PASS: The pull request changes only Cargo configuration in Cargo.tomland.cargo/config.toml. It adds build-profile and Cargo unstable settings, but it adds or changes no source modules. The modul…Testing (Property / Proof) The pull request changes only Cargo build configuration: [profile.dev]setsincremental = falseanddebug = 0, and.cargo/config.tomlenablesno-embed-metadata. These settings do not introdu…Testing (Compile-Time / Ui) Pass this check. The pull request changes only Cargo build configuration: [profile.dev]settings and Cargo'sno-embed-metadataoption. It introduces no Rust or TypeScript compile-time API behaviou…Unit Architecture PASS. Restrict the change to Cargo build configuration: [profile.dev]setsincremental = falseanddebug = 0, and[unstable]enablesno-embed-metadata. The pull request changes no Rust units…Domain Architecture Pass this check. The pull request changes only Cargo build configuration: [profile.dev]inCargo.tomland[unstable] no-embed-metadatain.cargo/config.toml. It does not change domain logic, a…Observability PASS — the pull request changes only Cargo build configuration. Cargo.toml:273-275disables incremental compilation and debug data for[profile.dev];.cargo/config.toml:31disables embedded comp…Description check The description states the PR applies the rust-dev-build-footprint concordat rule to wireframe by adding a [profile.dev] section (incremental = false, debug = 0) in Cargo.toml and an [unstable] embed-… Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: User-Facing Documentation
-
Explanation
Pass. The pull request changes only development build settings:
Cargo.tomldisables incremental compilation and debug data in[profile.dev], and.cargo/config.tomldisables embedded metadata. These settings affect build artefacts and developer tooling, not user-facing application or library behaviour. No user-guide update is required.
Full details: Module-Level Documentation
-
Explanation
PASS: The pull request changes only Cargo configuration in
Cargo.tomland.cargo/config.toml. It adds build-profile and Cargo unstable settings, but it adds or changes no source modules. The module-level documentation requirement is therefore not applicable.
Full details: Testing (Property / Proof)
-
Explanation
The pull request changes only Cargo build configuration:
[profile.dev]setsincremental = falseanddebug = 0, and.cargo/config.tomlenablesno-embed-metadata. These settings do not introduce an invariant over inputs, states, orderings, or transitions, and they do not introduce a lemma or proof assumption. No property test or exhaustive proof is required by this check.
Full details: Testing (Compile-Time / Ui)
-
Explanation
Pass this check. The pull request changes only Cargo build configuration:
[profile.dev]settings and Cargo'sno-embed-metadataoption. It introduces no Rust or TypeScript compile-time API behaviour, compiler diagnostic output, or UI output. No new trybuild or snapshot test is required. Existing trybuild coverage remains intests/compile_error.rsandwireframe_testing/tests/loom_api_surface.rs.
Full details: Unit Architecture
-
Explanation
PASS. Restrict the change to Cargo build configuration:
[profile.dev]setsincremental = falseanddebug = 0, and[unstable]enablesno-embed-metadata. The pull request changes no Rust units, APIs, queries, commands, dependencies, side-effects, or tests. The Unit Architecture criteria are therefore not applicable, and no separation or dependency-visibility failure is introduced.
Full details: Domain Architecture
-
Explanation
Pass this check. The pull request changes only Cargo build configuration:
[profile.dev]inCargo.tomland[unstable] no-embed-metadatain.cargo/config.toml. It does not change domain logic, adapters, transport, persistence, commands, repositories, or error handling. No domain-boundary failure is introduced.
Full details: Observability
-
Explanation
PASS — the pull request changes only Cargo build configuration.
Cargo.toml:273-275disables incremental compilation and debug data for[profile.dev];.cargo/config.toml:31disables embedded compiler metadata. The diff changes no runtime code, production telemetry, service boundary, queue, storage, or alert behaviour. Logs, metrics, tracing, and alerts are therefore not required by this check.
Full details: Description check
-
Explanation
The description states the PR applies the rust-dev-build-footprint concordat rule to wireframe by adding a [profile.dev] section (incremental = false, debug = 0) in Cargo.toml and an [unstable] embed-metadata = false entry in .cargo/config.toml. It also lists contract tests, a developer guide paragraph, and footprint measurements. This is directly related to the changeset, so the check passes. Note that the description and the objectives disagree on the nightly pin (the description says the pin is nightly-2026-10-22 and unchanged; the objectives say nightly-2026-03-26), the config key (embed-metadata = false versus no-embed-metadata = true), and the measured sizes (479M/246M versus 570M/247M). These discrepancies do not make the description off-topic, but the author should reconcile them.
-
Full details: Testing (Overall)
-
Explanation
The pull request changes development build behaviour in
Cargo.toml:273-274and.cargo/config.toml:30-31, but it adds no tests. The existingmake testtarget tests repository functionality, not build-footprint settings, and the existing workflow contract tests cover onlyrustflags. Those tests would continue to pass if these new settings were removed. The reported local build measurements are not committed automated tests.Resolution
Add a CI-enforced, substantive build-footprint test for the pinned nightly. Build in a fresh target directory and assert the required incremental, debug-info, and embedded-metadata properties, or run the
rust-dev-build-footprintconcordat rule as a failing gate. Ensure the test fails when any of the three settings is removed or inverted.
Full details: Testing (Unit And Behavioural)
-
Explanation
The pull request changes the externally observable development-build workflow, but it adds no automated test. The diff changes only
.cargo/config.tomlandCargo.toml; it addsno-embed-metadata = true,incremental = false, anddebug = 0. The existingmake testtarget runs workspace tests, but it does not verify these Cargo build settings or the resulting artefacts.Resolution
Add an automated integration or end-to-end build test. Run the pinned Cargo toolchain with a clean target directory, verify that the development profile disables incremental compilation and debug information, and verify that embedded metadata is disabled. Keep the test at the Cargo/build boundary rather than testing private helpers.
Full details: Developer Documentation
-
Explanation
The pull request changes the development build standard in
Cargo.toml([profile.dev],incremental = false,debug = 0) and.cargo/config.toml(no-embed-metadata = true). The changed-file diff contains no documentation update. The Development builds section documents the pinned nightly, linker, rustflags and Cranelift, but does not document these new development build settings (docs/developers-guide.md:945-1004).Resolution
Update
docs/developers-guide.mdin the Development builds section. Document that development builds disable incremental compilation and debug information, and that Cargo uses[unstable] no-embed-metadata = truewith the pinned nightly toolchain. State the scope and effect of these settings.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Disable incremental builds; let artefacts grow light.
Strip debug details from the development build.
Keep metadata from embedding in the output.
Cargo follows the settings, one build at a time.
Smaller artefacts depart into the night.
Comment @coderabbitai help to get the list of available commands.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideApplies the rust-dev-build-footprint rule to wireframe by disabling dev incremental compilation, debug data, and embedded Cargo metadata on the existing pinned nightly, reducing measured fresh-build usage by roughly 49% while passing local and CI validation. Flow diagram for reduced Rust development build footprintflowchart LR
Source[Source code] --> Cargo[Cargo dev build]
Cargo --> Profile[Dev profile\nincremental=false\ndebug=0]
Cargo --> Metadata[Embedded metadata=false]
Profile --> Target[Fresh target directory]
Metadata --> Target
Target --> Size[Build footprint\n479M to 246M]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Set incremental = false and debug = 0 in the default dev profile and set Cargo's embed-metadata = false for the pinned nightly-2026-10-22, per the concordat rust-dev-build-footprint rule. This reduces intermediate build artefact storage.
2feefd5 to
3ae0d52
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ae0d5256c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@coderabbitai Your latest pre-merge table (reviewed at 2feefd5, before this PR was rebased onto the new pin) shows ❌ rows for Testing (Overall) and Testing (Unit And Behavioural), and a Developer Documentation warning. At head ee1d6c6: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
git rev-parse HEAD
fd -a '^(build_standard_test\.py|developers-guide\.md|Cargo\.toml|config\.toml|AGENTS\.md)$' . | head -60
ast-grep outline tests/workflow_contracts/build_standard_test.py --items all
rg -n -C5 'incremental|embed.metadata|debug =|footprint|trade.off' docs/developers-guide.md Cargo.toml .cargo/config.toml tests/workflow_contracts/build_standard_test.py
gh pr view 791 --repo leynos/wireframe --json headRefOid,state,statusCheckRollup,reviews
gh api graphql -f query='query {
repository(owner:"leynos", name:"wireframe") {
pullRequest(number:791) {
comments(last:30) { nodes { author { login } body url } }
reviewThreads(first:100) {
pageInfo { hasNextPage endCursor }
nodes { isResolved isOutdated path comments(first:30) { nodes { author { login } body url } pageInfo { hasNextPage } } }
}
}
}
}'Length of output: 51087 🏁 Script executed: #!/bin/bash
set -euo pipefail
cat -n AGENTS.md
sed -n '75,100p;218,246p' tests/workflow_contracts/build_standard_test.py
sed -n '970,991p' docs/developers-guide.md
rg -n -C4 'test-workflow-contracts|workflow_contracts' Makefile .github
fd -H '^rust-toolchain(\.toml)?$' . --exec cat -n {}
gh api repos/leynos/wireframe/actions/jobs/120198160278 --jq '{conclusion,steps: [.steps[] | {name,conclusion}]}'Length of output: 32179
No review findings remain open. GitHub reports both review threads as resolved. The head’s CI build, lint, workflow contract tests, and security checks passed. Separate that assessment from the recorded review state: CodeRabbit’s You are interacting with an AI system. |
Part of DF12-110
Applies the concordat
rust-dev-build-footprintrule (0.2.1) to wireframe, the pilot of the footprint rollout, on the new pin nightly-2026-10-22 (#794).Cargo.toml: add[profile.dev]withincremental = falseanddebug = 0..cargo/config.toml: add[unstable] embed-metadata = false, the native Cargo key for dated nightlies from 2026-07-31. No raw rustc metadata flags are used. The pin is unchanged.tests/workflow_contracts/build_standard_test.pyanddocs/developers-guide.md: contract tests for the three settings, and a paragraph on the footprint rule, its debugging and rebuild trade-offs and the local overrides.Rule result (concordat at 0f0b419,
concordat artefact rule run rust-dev-build-footprint):Footprint evidence, one dev
cargo buildinto a fresh target directory each, run sequentially on nightly-2026-10-22:du -sh target479MLocal gates (through the gate slot, sequential):
make check-fmt,make lintandmake testall pass.First main push after #794 (Coverage (main), Push on main, CI): all succeeded on ubicloud runners with no out-of-disk failure. The wireframe workflows have no free-disk telemetry, so no least-free-disk figure exists. This change invalidates the sccache keys again.
Overlapping open PRs: none touch
Cargo.tomlor.cargo/config.toml; #650 touches onlytools/dev-fast/config.toml.