Repository navigation
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis structural refactor moves three self-named Rust module files to File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
SummaryMove three directory-backed Rust modules to
Update the ChecksGitHub’s build-test, CodeQL and CodeScene checks pass on head WalkthroughTwo test module path attributes now point to different file locations. No scheduler behaviour or public declarations changed. ChangesTest module path updates
Priority: ⬇️ Low Change: Refactor Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Testing (Compile-Time / Ui) |  |
The pull request changes Rust compile-time module resolution: three module files move to mod.rs, and two #[path] attributes change. The authoritative diff contains only three renames and two path … |
Add a focused trybuild pass fixture under tests/ui and register it in tests/compile_error.rs. Compile the relevant feature configuration so the moved metrics, server, and scheduler modules and both adjusted test paths are resolved… |
-
Check name Status Explanation Title check The title "Move self-named module files to mod.rs form" clearly summarises the main change: three self-named module files (metrics.rs, server/runtime/server.rs, client/pool/scheduler.rs) are moved to … Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Testing (Overall) PASS: The pull request introduces no new functionality or behavioural logic. The diff contains only three file relocations: src/metrics.rstosrc/metrics/mod.rsis byte-identical, and the schedule…User-Facing Documentation The pull request only renames three internal Rust module files to mod.rsand adjusts two test#[path]attributes. The diff shows no user-facing functionality, API, CLI behaviour, or usage change. …Developer Documentation Pass. The pull request only relocates three Rust module files to mod.rspaths. The only content changes recompute two test#[path]attributes. No internal API, architectural boundary, abstraction,…Module-Level Documentation Pass. Keep the existing module-level documentation. The three moved modules retain //!docstrings at the start ofsrc/metrics/mod.rs:1,src/server/runtime/server/mod.rs:1, and `src/client/pool/s…Testing (Unit And Behavioural) Pass the testing check. The diff only renames three Rust module files and updates two relative #[path] attributes. It introduces no local behaviour, error path, invariant, or externally observable wor… Testing (Property / Proof) PASS — Do not add property tests. The pull request only moves three Rust module files and updates two #[path]attributes. The diff shows no runtime logic, input range, state transition, ordering inv…Unit Architecture Accept the change for Unit Architecture. The reviewed range contains only three file moves and two relative #[path]updates.src/metrics.rsmoves unchanged tosrc/metrics/mod.rs; the other modul…Domain Architecture Pass. The pull request only relocates three Rust module files to mod.rspaths. The only content changes are two test#[path]attributes, adjusted for the new file locations;src/metrics.rsis by…Observability Pass the observability check. The pull request only renames three Rust module files. It changes two test-module paths to match the new locations and makes no operational behaviour, logging, metrics, t… Description check The pull request description directly matches the changeset. It explains the three module moves, the updated #[path] attributes, the preserved content, and the lint objective. Full details: Title check
-
Explanation
The title "Move self-named module files to mod.rs form" clearly summarises the main change: three self-named module files (metrics.rs, server/runtime/server.rs, client/pool/scheduler.rs) are moved to mod.rs paths, as stated in the objectives and description. The title does not reference a roadmap item or issue number, and the title requirements in this context do not mandate one because no roadmap task or GitHub issue is referenced in the PR description. No execplan is involved, so the prefix rules do not apply.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
Full details: Testing (Overall)
-
Explanation
PASS: The pull request introduces no new functionality or behavioural logic. The diff contains only three file relocations:
src/metrics.rstosrc/metrics/mod.rsis byte-identical, and the scheduler and server files retain their content apart from corrected#[path]attributes. The existing substantive test modules remain present and correctly referenced by../scheduler_tests.rsandobservation_tests.rs. No additional tests are required by this check for a structural-only change.
Full details: User-Facing Documentation
-
Explanation
The pull request only renames three internal Rust module files to
mod.rsand adjusts two test#[path]attributes. The diff shows no user-facing functionality, API, CLI behaviour, or usage change. No user-guide update is required.
Full details: Developer Documentation
-
Explanation
Pass. The pull request only relocates three Rust module files to
mod.rspaths. The only content changes recompute two test#[path]attributes. No internal API, architectural boundary, abstraction, tooling requirement, build requirement, roadmap item, or new execplan changes. No developer-guide or design-document update is required.
Full details: Module-Level Documentation
-
Explanation
Pass. Keep the existing module-level documentation. The three moved modules retain
//!docstrings at the start ofsrc/metrics/mod.rs:1,src/server/runtime/server/mod.rs:1, andsrc/client/pool/scheduler/mod.rs:1. These docs state each module's purpose and function. The metrics documentation also identifies its relationship to themetricscrate. The pull request changes only file paths and two test-module paths; it removes no required module documentation.
Full details: Testing (Unit And Behavioural)
-
Explanation
Pass the testing check. The diff only renames three Rust module files and updates two relative #[path] attributes. It introduces no local behaviour, error path, invariant, or externally observable workflow. Existing scheduler and server tests remain in place, and the updated paths point to the existing test files.
Full details: Testing (Property / Proof)
-
Explanation
PASS — Do not add property tests. The pull request only moves three Rust module files and updates two
#[path]attributes. The diff shows no runtime logic, input range, state transition, ordering invariant, lemma, or proof assumption. The module-path edits are directly auditable.
Full details: Unit Architecture
-
Explanation
Accept the change for Unit Architecture. The reviewed range contains only three file moves and two relative
#[path]updates.src/metrics.rsmoves unchanged tosrc/metrics/mod.rs; the other modules retain their contents apart from paths to existing test files. The diff adds no query, command, dependency, fallibility, state, or responsibility changes.
Full details: Domain Architecture
-
Explanation
Pass. The pull request only relocates three Rust module files to
mod.rspaths. The only content changes are two test#[path]attributes, adjusted for the new file locations;src/metrics.rsis byte-identical after the move. No domain logic, adapter boundary, dependency, command invariant, or external-system handling changes.
Full details: Observability
-
Explanation
Pass the observability check. The pull request only renames three Rust module files. It changes two test-module paths to match the new locations and makes no operational behaviour, logging, metrics, tracing, or alert changes.
-
Full details: Testing (Compile-Time / Ui)
-
Explanation
The pull request changes Rust compile-time module resolution: three module files move to
mod.rs, and two#[path]attributes change. The authoritative diff contains only three renames and two path edits; it adds no compile-time test. The repository has a trybuild harness intests/compile_error.rs, but its existing fixtures cover unrelated public API contracts. This does not meet the required trybuild coverage for the introduced compile-time behaviour.Resolution
Add a focused trybuild pass fixture under
tests/uiand register it intests/compile_error.rs. Compile the relevant feature configuration so the movedmetrics,server, andschedulermodules and both adjusted test paths are resolved by the compiler.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Point the paths to files anew.
Keep each test module in view.
Scheduler takes one step above.
Server finds its file close by.
Let both test paths compile true.
Comment @coderabbitai help to get the list of available commands.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Clippy's `self_named_module_files` requires a directory-backed module to live in `mod.rs`. Three modules already had a sibling directory, so each `foo.rs` is now `foo/mod.rs` with `git mv`, keeping the change content-preserving: - `src/metrics.rs` -> `src/metrics/mod.rs` - `src/server/runtime/server.rs` -> `src/server/runtime/server/mod.rs` - `src/client/pool/scheduler.rs` -> `src/client/pool/scheduler/mod.rs` The `#[path]` attributes pointing at test modules were recomputed against the new locations, not simply retained. `scheduler_tests.rs` stays in the parent directory and now uses `../scheduler_tests.rs`; `observation_tests.rs` already lived in `server/`, so its attribute drops the now-redundant `server/` prefix. Co-Authored-By: Claude Code <noreply@anthropic.com>
cc48b70 to
d493667
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4936677f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| #[cfg(test)] | ||
| #[path = "scheduler_tests.rs"] | ||
| #[path = "../scheduler_tests.rs"] |
There was a problem hiding this comment.
This move leaves current traceability documentation pointing to files that no longer exist: docs/adr-013-client-pool-scheduler-and-slot-ownership.md:110 names src/client/pool/scheduler.rs, docs/adr-014-server-shutdown-ownership.md:41-45 names both src/server/runtime/server.rs and src/metrics.rs, and docs/users-guide.md:2857 also names src/metrics.rs. Update these active references to their new mod.rs paths so the repository's documented source surfaces remain navigable; historical execution-plan references can remain unchanged.
AGENTS.md reference: AGENTS.md:L44-L47
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Scope
Structural layer only: three
foo.rsfiles with an existingfoo/directory become
foo/mod.rs, satisfying Clippy'sself_named_module_filesahead of the final lint configuration. Content is preserved; every file below
the move is byte-identical apart from the recomputed
#[path]attributes.src/metrics.rs->src/metrics/mod.rssrc/server/runtime/server.rs->src/server/runtime/server/mod.rssrc/client/pool/scheduler.rs->src/client/pool/scheduler/mod.rsscheduler_tests.rsstays in the parent directory, so its attribute becomes../scheduler_tests.rs.observation_tests.rsalready lived insideserver/,so its attribute drops the now-redundant
server/prefix. Both were recomputedagainst the new location rather than retained blindly.
Position and dependencies
Layer 4 of 5. Stacked on the examples layer, and the parent of the census
layer that closes the stack.
harden-lint-examples-20261022(Fix example lint findings and inject the environment boundary #797)harden-lint-census-completion-20261022(Clear the helper-crate lint census #805)Reviewer entrypoints
src/client/pool/scheduler/mod.rs:395andsrc/server/runtime/server/mod.rs:398— the two recomputed#[path]attributes
git mvrenames with no content changeValidation evidence (head
d493667)This branch was restacked onto
origin/main=b194531on 2026-10-23, aftermain moved three commits including #794's toolchain bump from
nightly-2026-03-26tonightly-2026-10-22. The previous headcc48b70and itslocal gate results belong to the retired toolchain and are not current
evidence.
The
weavemerge driver was disabled for the replay(
-c core.attributesFile=/dev/null), and the replay was checked against adriver-free
merge-treeresult rather than trusted.Hosted, at this head. The
build-testlane ran at this exact commit andpassed every step. It executes the repository's own targets, so its result is
per-layer evidence for the format and lint gates rather than a result inherited
from a neighbour:
make check-fmtmake lint— rustdoc with-D warnings, Clippy with-D warnings, Whitaker--allmarkdownlint-cli2over**/*.mdmake spellingmake nixiemake test-workflow-contractsmake test-feature-gatecargo llvm-cov nextest --workspace, default features and targetshttps://github.com/leynos/wireframe/actions/runs/39959689502/job/120434257945
The instrumented run executed 1207 tests, 1207 passed, 0 skipped and
reported 87.79%, a 0.01 pp fall from the committed 87.8% baseline that is
inside the ratchet's tolerance band.
Read from the job log, not inferred from the job conclusion.
That run is narrower than the Make targets — no
--all-targets, no--all-features, no doctests — which is why the local runs below are stillrequired.
Local. Run sequentially at this exact head with
make:Known baseline failures
None observed at this head.
Deferred work
Remaining source census findings, final lint-configuration adoption, the
testkit argument-count decision and Whitaker
--workspacecoverage.Summary by Sourcery
Enhancements:
mod.rslocations while preserving their contents and updating affected test paths.References
harden-lint-census-completion-20261022)gate run and the census this layer defers to.
unsafe_code = "forbid"can apply workspace-wide #804 — isolate the unsafe allocator sounsafe_code = "forbid"can applyworkspace-wide.
/home/leynos/docs/leynos-wireframe/rust-baseline/2026-10-15/train-ledger.md🤖 Generated with Claude Code