Skip to content

Minor code style and typo fixes#48

Open
AneesHl wants to merge 7 commits into
lf-lang:mainfrom
AneesHl:minor-code-style-and-typo-fixes
Open

Minor code style and typo fixes#48
AneesHl wants to merge 7 commits into
lf-lang:mainfrom
AneesHl:minor-code-style-and-typo-fixes

Conversation

@AneesHl

@AneesHl AneesHl commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

I fixed few minor things that my IDE was complaining about.

@lhstrh lhstrh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your IDE seems to care a lot about grammar!

Comment thread Cargo.toml
[features]
default=["vec-id-sets"]
# Enable the parallel runtime implementation todo make default
# Enable the parallel runtime implementation # TODO make default

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little weird. Also, I'm not sure I understand what's left to do.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to make the parallel-runtime feature a default feature of the crate. Currently if you want parallel execution you need to enable it explicitly with a lot of ceremony: https://github.com/lf-lang/lingua-franca/blob/4f8d8893574e3c76fd30c2515c9be9a7444e4f1f/test/Rust/src/target/CargoDependencyOnRuntime.lf#L5

Comment thread src/scheduler/context.rs Outdated
@oowekyala

Copy link
Copy Markdown
Collaborator

Looks like we have a couple of build issues:

/usr/bin/git push origin gh_pages
remote: Permission to lf-lang/reactor-rs.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/lf-lang/reactor-rs.git/': The requested URL returned error: 403

  • Running lf-tests doesn't work, AFAICT because the source branch of this PR is in Anees' fork and not in the main repo. Then it fails while fetching the branch, because only the upstream remote is known.

@lhstrh lhstrh requested a review from cmnrd May 31, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants