Feature: CNF Installation (4) Group several manifest into one file#2150
Merged
Conversation
4 tasks
barmull
force-pushed
the
#2125-create-common-manifest
branch
2 times, most recently
from
3a123e2 to
0d92ced
Compare
svteb
reviewed
Sep 24, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
0d92ced to
370c35f
Compare
kosstennbl
requested changes
Sep 26, 2024
Collaborator
kosstennbl
left a comment
kosstennbl
left a comment
There was a problem hiding this comment.
Nice change!
We should also not forget to modify shard files after PR in Helm repo would be merged.
Some comments and possible changes below:
barmull
force-pushed
the
#2125-create-common-manifest
branch
2 times, most recently
from
8bdf96c to
552616c
Compare
martin-mat
requested changes
Sep 30, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
3 times, most recently
from
dc84367 to
9713630
Compare
martin-mat
requested changes
Oct 3, 2024
barmull
force-pushed
the
#2125-create-common-manifest
branch
3 times, most recently
from
d57ddca to
0a83d77
Compare
Collaborator
|
Tested, found some mistakes: common_manifest is not deleted on cnf_cleanup (should be) |
barmull
force-pushed
the
#2125-create-common-manifest
branch
3 times, most recently
from
ba61349 to
cebe752
Compare
svteb
reviewed
Oct 8, 2024
Collaborator
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
cebe752 to
f4021c8
Compare
Collaborator
Author
|
Also need to add namespaces into workload resources by updating generated_manifest. |
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
f4021c8 to
bd35849
Compare
barmull
force-pushed
the
#2125-create-common-manifest
branch
6 times, most recently
from
14a6bff to
7ee8aa8
Compare
kosstennbl
requested changes
Oct 21, 2024
Collaborator
kosstennbl
left a comment
kosstennbl
left a comment
There was a problem hiding this comment.
Some changes, mostly cosmetic
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
7ee8aa8 to
642dc1d
Compare
martin-mat
requested changes
Oct 21, 2024
Collaborator
|
remove from "Draft"? |
barmull
force-pushed
the
#2125-create-common-manifest
branch
2 times, most recently
from
212ddc2 to
b432047
Compare
- group manifests from several CNFs into one common_manifests.yaml file - add functionality in cleanup.cr to remove this file - depends on PR in helm library: cnf-testsuite/helm#4 - common_manifest functionality: used common_manifest instead of templates - remove methods related to templates - update generated manifest: add namespace to each resource Signed-off-by: barmull <barbora.muller@tietoevry.com>
barmull
force-pushed
the
#2125-create-common-manifest
branch
from
b432047 to
24744bc
Compare
collivier
pushed a commit
to collivier/testsuite
that referenced
this pull request
Nov 13, 2024
- group manifests from several CNFs into one common_manifests.yaml file - add functionality in cleanup.cr to remove this file - depends on PR in helm library: cnf-testsuite/helm#4 - common_manifest functionality: used common_manifest instead of templates - remove methods related to templates - update generated manifest: add namespace to each resource Signed-off-by: barmull <barbora.muller@tietoevry.com>
LuciaSirova
pushed a commit
that referenced
this pull request
Mar 27, 2025
- group manifests from several CNFs into one common_manifests.yaml file - add functionality in cleanup.cr to remove this file - depends on PR in helm library: cnf-testsuite/helm#4 - common_manifest functionality: used common_manifest instead of templates - remove methods related to templates - update generated manifest: add namespace to each resource Signed-off-by: barmull <barbora.muller@tietoevry.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gather all the manifest files from the various CNFs into a single file called common_manifests.yaml
Modified temp_template.yaml to reference common_manifests.yaml
Removed code responsible for generating CNF templates as it is no longer used
Added functionality in cleanup.cr to remove common_manifests.yaml as part of the cleanup process
Update generated manifest, add namespace to each resource
Depends on PR in helm library: Feature: Add method generate_manifest cnf-testsuite/helm#4
Issues:
Refs: #2125
Re-created from different branch, old PR: #2144