Skip to content

🛡️ Sentinel: [security improvement] Add CORS and TrustedHost middlewares#15

Closed
lgcorzo wants to merge 1 commit into
mainfrom
sentinel-add-security-middlewares-4241211773520171717
Closed

🛡️ Sentinel: [security improvement] Add CORS and TrustedHost middlewares#15
lgcorzo wants to merge 1 commit into
mainfrom
sentinel-add-security-middlewares-4241211773520171717

Conversation

@lgcorzo
Copy link
Copy Markdown
Owner

@lgcorzo lgcorzo commented Feb 7, 2026

🛡️ Sentinel: [security improvement]

Context: The FastAPI application was missing CORSMiddleware and TrustedHostMiddleware, which are essential for security in web applications.

Changes:

  • Added CORSMiddleware and TrustedHostMiddleware to src/regression_model_template/controller/kafka_app.py.
  • Introduced ALLOWED_ORIGINS and ALLOWED_HOSTS environment variables for configuration.
  • Defaulted ALLOWED_ORIGINS and ALLOWED_HOSTS to * to maintain backward compatibility, but allow operators to restrict access.

Verification:

  • Verified that middlewares are present and correctly configured using a temporary test script.
  • Ran existing security tests (tests/controller/test_kafka_app_security.py) and full checks (poetry run invoke checks).

PR created automatically by Jules for task 4241211773520171717 started by @lgcorzo

Add `CORSMiddleware` and `TrustedHostMiddleware` to `src/regression_model_template/controller/kafka_app.py` to improve security.
Configuration is managed via `ALLOWED_ORIGINS` and `ALLOWED_HOSTS` environment variables.

Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@lgcorzo lgcorzo closed this Feb 25, 2026
@lgcorzo lgcorzo deleted the sentinel-add-security-middlewares-4241211773520171717 branch February 25, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant