Skip to content

🛡️ Sentinel: Add CORS and TrustedHost middleware for security hardening#16

Closed
lgcorzo wants to merge 1 commit into
mainfrom
sentinel-add-security-middleware-16277937647812599225
Closed

🛡️ Sentinel: Add CORS and TrustedHost middleware for security hardening#16
lgcorzo wants to merge 1 commit into
mainfrom
sentinel-add-security-middleware-16277937647812599225

Conversation

@lgcorzo
Copy link
Copy Markdown
Owner

@lgcorzo lgcorzo commented Feb 8, 2026

This PR adds CORSMiddleware and TrustedHostMiddleware to the regression_model_template application to mitigate potential Host Header Injection attacks and allow granular control over Cross-Origin Resource Sharing (CORS).

Changes:

  • Imported CORSMiddleware and TrustedHostMiddleware in src/regression_model_template/controller/kafka_app.py.
  • Added configuration for ALLOWED_ORIGINS and ALLOWED_HOSTS environment variables (defaulting to * for backward compatibility).
  • Added middleware registration to the FastAPI app instance.
  • Added tests/controller/test_kafka_app_middleware.py to verify the middleware configuration.

Verification:

  • New test tests/controller/test_kafka_app_middleware.py passes.
  • Full CI suite (poetry run invoke checks) passes.

PR created automatically by Jules for task 16277937647812599225 started by @lgcorzo

- Added `CORSMiddleware` and `TrustedHostMiddleware` to `kafka_app.py`.
- Exposed `ALLOWED_ORIGINS` and `ALLOWED_HOSTS` configuration via environment variables.
- Verified configuration via `tests/controller/test_kafka_app_middleware.py`.
- Passed full CI suite.

Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@lgcorzo lgcorzo closed this Feb 25, 2026
@lgcorzo lgcorzo deleted the sentinel-add-security-middleware-16277937647812599225 branch February 25, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant