π‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost Middleware#17
π‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost Middleware#17lgcorzo wants to merge 2 commits into
Conversation
- Added `CORSMiddleware` and `TrustedHostMiddleware` to `kafka_app.py`. - Configured middleware using `ALLOWED_ORIGINS` and `ALLOWED_HOSTS` environment variables with safe defaults. - Added `tests/controller/test_middleware_security.py` to verify middleware configuration. - Verified changes with tests and linting. Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `CORSMiddleware` and `TrustedHostMiddleware` to `kafka_app.py`. - Configured middleware using `ALLOWED_ORIGINS` and `ALLOWED_HOSTS` environment variables with safe defaults. - Added `tests/controller/test_middleware_security.py` to verify middleware configuration. - Formatted `tests/controller/test_middleware_security.py` to pass CI checks. Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
π‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost Middleware
π¨ Severity: HIGH
π‘ Vulnerability: The FastAPI application lacked
CORSMiddlewareandTrustedHostMiddleware, making it susceptible to Cross-Origin Resource Sharing attacks (if accessed via browser) and Host Header attacks.π― Impact: Attackers could potentially access the API from unauthorized origins or manipulate the Host header to poison links or cache.
π§ Fix: Added
CORSMiddlewareandTrustedHostMiddlewaretosrc/regression_model_template/controller/kafka_app.py. Configured them to read fromALLOWED_ORIGINSandALLOWED_HOSTSenvironment variables, defaulting to*to maintain current behavior while enabling restriction.β Verification: Created
tests/controller/test_middleware_security.pywhich verifies that the middlewares are correctly added to the application stack and configured as expected. Ran full test suite to ensure no regressions.PR created automatically by Jules for task 7623378519933595398 started by @lgcorzo