Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost Middleware#17

Closed
lgcorzo wants to merge 2 commits into
mainfrom
sentinel-middleware-security-7623378519933595398
Closed

πŸ›‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost Middleware#17
lgcorzo wants to merge 2 commits into
mainfrom
sentinel-middleware-security-7623378519933595398

Conversation

@lgcorzo
Copy link
Copy Markdown
Owner

@lgcorzo lgcorzo commented Feb 9, 2026

πŸ›‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost Middleware

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The FastAPI application lacked CORSMiddleware and TrustedHostMiddleware, making it susceptible to Cross-Origin Resource Sharing attacks (if accessed via browser) and Host Header attacks.
🎯 Impact: Attackers could potentially access the API from unauthorized origins or manipulate the Host header to poison links or cache.
πŸ”§ Fix: Added CORSMiddleware and TrustedHostMiddleware to src/regression_model_template/controller/kafka_app.py. Configured them to read from ALLOWED_ORIGINS and ALLOWED_HOSTS environment variables, defaulting to * to maintain current behavior while enabling restriction.
βœ… Verification: Created tests/controller/test_middleware_security.py which verifies that the middlewares are correctly added to the application stack and configured as expected. Ran full test suite to ensure no regressions.


PR created automatically by Jules for task 7623378519933595398 started by @lgcorzo

- Added `CORSMiddleware` and `TrustedHostMiddleware` to `kafka_app.py`.
- Configured middleware using `ALLOWED_ORIGINS` and `ALLOWED_HOSTS` environment variables with safe defaults.
- Added `tests/controller/test_middleware_security.py` to verify middleware configuration.
- Verified changes with tests and linting.

Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Added `CORSMiddleware` and `TrustedHostMiddleware` to `kafka_app.py`.
- Configured middleware using `ALLOWED_ORIGINS` and `ALLOWED_HOSTS` environment variables with safe defaults.
- Added `tests/controller/test_middleware_security.py` to verify middleware configuration.
- Formatted `tests/controller/test_middleware_security.py` to pass CI checks.

Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
@lgcorzo lgcorzo closed this Feb 25, 2026
@lgcorzo lgcorzo deleted the sentinel-middleware-security-7623378519933595398 branch February 25, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant