Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost middleware#19

Closed
lgcorzo wants to merge 2 commits into
mainfrom
sentinel-add-security-middleware-15023835416815364786
Closed

πŸ›‘οΈ Sentinel: [HIGH] Add CORS and TrustedHost middleware#19
lgcorzo wants to merge 2 commits into
mainfrom
sentinel-add-security-middleware-15023835416815364786

Conversation

@lgcorzo
Copy link
Copy Markdown
Owner

@lgcorzo lgcorzo commented Feb 11, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Overly permissive CORS configuration and Missing TrustedHostMiddleware.
🎯 Impact:
- Without CORS, legitimate cross-origin requests are blocked by browsers.
- Without TrustedHostMiddleware, the application is vulnerable to Host Header attacks.
πŸ”§ Fix:
- Added CORSMiddleware and TrustedHostMiddleware to src/regression_model_template/controller/kafka_app.py.
- Configured them via ALLOWED_ORIGINS and ALLOWED_HOSTS environment variables.
βœ… Verification:
- Added tests/controller/test_kafka_app_middleware.py which verifies that the middlewares are present and correctly configured.


PR created automatically by Jules for task 15023835416815364786 started by @lgcorzo

- Added CORSMiddleware and TrustedHostMiddleware to kafka_app.py
- Configured via ALLOWED_ORIGINS and ALLOWED_HOSTS env vars
- Added tests for middleware presence and configuration

Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Added CORSMiddleware and TrustedHostMiddleware to kafka_app.py
- Configured via ALLOWED_ORIGINS and ALLOWED_HOSTS env vars
- Added tests for middleware presence and configuration
- Fixes CI failure by formatting code with ruff

Co-authored-by: lgcorzo <46710567+lgcorzo@users.noreply.github.com>
@lgcorzo lgcorzo closed this Feb 25, 2026
@lgcorzo lgcorzo deleted the sentinel-add-security-middleware-15023835416815364786 branch February 25, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant