fix(keyboard): return to the files when Right leaves the sidebar - #1088
Open
spandan11106 wants to merge 1 commit into
Open
spandan11106 wants to merge 1 commit into
spandan11106 wants to merge 1 commit into
Conversation
Entering the sidebar from the navigation header stored the focused header button as the return target, so Right restored Back/Refresh instead of the listing and the file view could only be re-entered with the mouse. Remember a return target only while the file view holds focus; otherwise Right falls back to the active item, matching the file chooser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Entering the sidebar from the navigation header stored the focused header button as
the sidebar's return target, so Right restored Back/Refresh instead of the listing.
Once keyboard focus had left the file view, the only way back into it was the mouse.
A return target is now remembered only while the file view holds focus; otherwise Right
falls back to the active item, which is what the file chooser already did. Affects List,
Icons, and Columns.
Visual evidence
Pending — the change is a keyboard-focus ring, and I could not upload stills from this
session. Reproducible by hand with the steps below.
How to test
button rather than a filename.
Expected result: focus returns to the file list and the arrow keys move between files
again. Before this change, Right focused Back (List/Icons) or Refresh (Columns), and the
listing could only be re-entered with the mouse. Left from a focused file row into the
sidebar still returns to that exact row.
Related issue
Closes #1053