feat(browser): add window-level tabs with a docked tab strip - #375
Open
JoeJoeflyn wants to merge 3 commits into
Open
JoeJoeflyn wants to merge 3 commits into
JoeJoeflyn wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108 (pane-specific items deferred until #83 lands).
What changed
TabsModel(src/ui/tabs.rs): each tab owns an independent liveBrowserViewin a sharedgtk::Stack, so switching is instant and inactive tabs keep their locations, histories, and selections.+header button is always visible. Styling reuses the column-header visual language with semantic@theme_*colors.Ctrl+Shift+Tnew tab,Ctrl+Wclose,Ctrl+Tab/Ctrl+Shift+TabandCtrl+PgDn/Ctrl+PgUpswitch,Ctrl+1–Ctrl+9direct select,Ctrl+Schord group (T/N/P/X/digits) per the issue's proposal,Ctrl+Shift+PgUp/PgDnreorder.Manual steps
cargo run, pressCtrl+Shift+Tor click the header+→ tab strip appears above the file list with the current folder's name.Ctrl+Tab,Ctrl+2, or by clicking tabs; breadcrumb, sidebar highlight, and keyboard focus follow the active tab.Ctrl+Wto close; the last tab refuses to close.Expected result
Multiple independent workspaces in one window, each keeping its own history and selection, with no observer leaks on close.
Skipped for v1: session persistence (out of scope per #108) and detach-tab-to-window.
N/A — screenshots: tab strip styling reuses existing column-header CSS; behavior is interactive (drag/reorder/drop) and not capturable in a still.
