Prevent combat drop when creature charms expire while the creature is in combat#83
Open
bladezLH wants to merge 3 commits intolh-server:developmentfrom
Open
Prevent combat drop when creature charms expire while the creature is in combat#83bladezLH wants to merge 3 commits intolh-server:developmentfrom
bladezLH wants to merge 3 commits intolh-server:developmentfrom
Conversation
Contributor
bladezLH
commented
May 14, 2018
- The combat end timer will begin to tick once a unit's hated list is empty. Therefore, we should ensure that the caster is still on the threat list after a successful charm
- We should potentially restore a unit's threat list from before the charm rather than wiping it and only adding the caster
- Removed Kel'Thuzad specific MC handling
- Ensure Kel'Thuzad properly enters combat with the instance
ratkosrb
reviewed
May 14, 2018
| } | ||
| else | ||
| { | ||
| Creature *pCasterCreature = caster ? caster->ToCreature() : nullptr; |
Contributor
There was a problem hiding this comment.
You can use ToCreature(caster) here instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.