Close temporary socket

[kuznetsss]

No description provided.

[liaan]

Hi, what reasoning behind this? I'm to lazy to go check code now, so cannot remmeber what it does

[kuznetsss]

Hi, to get an IP address to bind you open socket and connect to 8.8.8.8 and leave the socket open but the socket is not used anywhere after obtaining the IP address.

[liaan]

Does it still work with this.. thought original idea was to keep the udp socket open for answering. Will check when I have moment From: Sergey Kuznetsov ***@***.***> Sent: Wednesday, 15 June 2022 09:33 To: liaan/broadlink_ac_mqtt ***@***.***> Cc: Karman de Lange ***@***.***>; Comment ***@***.***> Subject: Re: [liaan/broadlink_ac_mqtt] Close temporary socket (PR #97) Hi, to get an IP address to bind you open socket and connect to 8.8.8.8 and leave the socket open but the socket is not used anywhere after obtaining the IP address. - Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fliaan%2Fbroadlink_ac_mqtt%2Fpull%2F97%23issuecomment-1156098392&data=05%7C01%7C%7C27d04512c12544a4715108da4ea1500e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637908751986683366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qDd0flan4PcAt27o4l9SRyvvbny58BoUi6BuahhKgT0%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAGTCX4FRR6ITDPSOOHBPBDVPGBLXANCNFSM5YZAUXOQ&data=05%7C01%7C%7C27d04512c12544a4715108da4ea1500e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637908751986683366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=A63gyAk6senrBcHARAUYlMIRtfAGTTxHBDwSHMCFs7I%3D&reserved=0>. You are receiving this because you commented.Message ID: ***@***.******@***.***>>

[kuznetsss]

You open socket to communicate with a device here

broadlink_ac_mqtt/broadlink_ac_mqtt/classes/broadlink/ac_db.py

Line 140 in a2a6e2d

self.cs = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)

[liaan]

Thanks.. I’ll check Wrote the code way to long ago to even try remember.. was my first python project as well, so had no clue 😉 (not like I have any now) From: Sergey Kuznetsov ***@***.***> Sent: Wednesday, 15 June 2022 10:39 To: liaan/broadlink_ac_mqtt ***@***.***> Cc: Karman de Lange ***@***.***>; Comment ***@***.***> Subject: Re: [liaan/broadlink_ac_mqtt] Close temporary socket (PR #97) You open socket to communicate with a device here https://github.com/liaan/broadlink_ac_mqtt/blob/a2a6e2dfdc31a8e2b790604666ff144a97419d60/broadlink_ac_mqtt/classes/broadlink/ac_db.py#L140<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fliaan%2Fbroadlink_ac_mqtt%2Fblob%2Fa2a6e2dfdc31a8e2b790604666ff144a97419d60%2Fbroadlink_ac_mqtt%2Fclasses%2Fbroadlink%2Fac_db.py%23L140&data=05%7C01%7C%7C27747548f31048c28f9d08da4eaa849e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637908791512810888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ya1LVvAC1wU7pVUImzXHBpJGsaA3iSYvH10ZSH40I6Y%3D&reserved=0> — Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fliaan%2Fbroadlink_ac_mqtt%2Fpull%2F97%23issuecomment-1156171641&data=05%7C01%7C%7C27747548f31048c28f9d08da4eaa849e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637908791512810888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mI3YHTUtsIH4aUaipV8opGAIrcWi9qV2knNPtm6bELU%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAGTCXZW22MMWX6KBYGZZIDVPGJC3ANCNFSM5YZAUXOQ&data=05%7C01%7C%7C27747548f31048c28f9d08da4eaa849e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637908791512810888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gtG5E%2BGefxGCm7rtmNgkcs2TzT4ThPOwCiXq%2FQFUPvk%3D&reserved=0>. You are receiving this because you commented.Message ID: ***@***.******@***.***>>