Repository navigation
Open a side conversation beside its parent, and hand findings back through a compose buffer - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes, plus a review round on top of them.
Where a side conversation opens
New
agent-shell-side-display-action, defaulting to a 40% window on theright. The parent keeps using upstream's
agent-shell-display-action; itis an ordinary shell. Closing a side conversation deletes its side window
rather than handing the parent a narrow strip. Toggling with both on
screen now selects the other window instead of duplicating the side.
Setting the option to
display-buffer-same-windowreproduces the oldbehaviour exactly, so nothing needed a special case. Under viewport
interaction the action is not consulted: the viewport owns its layout.
One handback path
Findings always go into the parent's compose buffer now, whatever
agent-shell-prefer-viewport-interactionsays. That setting decideswhere the user's own prompts go and has no business deciding what happens
to findings.
This deletes the wait-for-idle machinery:
--stage-when-idle,--parent-busy-p, the pending flag, its mode-line marker, and theagent-shell-side-handback-submitoption. A compose buffer takes textmid-turn and offers send, queue, or steer from its own keys. Waiting
could only ever offer send, and only later.
Review fixes (624b7e0)
concludesignalled "Not yet supported" when run from a composebuffer.
agent-shell-insertdispatches on the current buffer, not thetarget. Both call sites now address the side shell directly.
queued draft into a steer. The in-progress draft's disposition is now
carried through.
--closewas dead:kill-bufferalreadydeletes a dedicated side window. Removed.
arrival is now stated in the README.
Verification
make checkgreen, 107/107. The three new tests fail against 30236f8,as does an existing viewport test that had been passing vacuously
because the stub did not dispatch. Byte-compiles clean against the real
agent-shell, shell-maker and acp; checkdoc clean.
Not verified:
make live-checkhas not been re-run against a real agentsince the handback moved. Its probes were updated to match but the run
has not happened, and DESIGN.md and the README now say so.