Conversation
|
|
||
| return s; | ||
| } | ||
|
|
There was a problem hiding this comment.
I like the extra line at the end of files, though. And, technically all non-empty source files must end in a new line according to the C standard: http://gcc.gnu.org/ml/gcc/2003-11/msg01568.html
There was a problem hiding this comment.
Currently (without my commit) there are 2 empty lines. The view of GitHub hides the last one. Check the file with cat.
| { "Simple Tests", "test_ck_abort", CK_FAILURE, CK_MSG_TEXT, "Failed" }, | ||
| { "Simple Tests", "test_ck_abort_msg", CK_FAILURE, CK_MSG_TEXT, "Failure expected" }, | ||
| { "Simple Tests", "test_ck_abort_msg_null", CK_FAILURE, CK_MSG_TEXT, "Failed" }, | ||
| { "Simple Tests", "test_ck_assert", CK_FAILURE, CK_MSG_TEXT, "Assertion 'x == y' failed" }, |
There was a problem hiding this comment.
I know that these are really long lines, but I do prefer each entry to be on one line. At least for this table, that is. Some of the other long line examples that you have edited are fine.
| tr = tr_fail_array[i - passed]; | ||
| ck_assert_msg(tr != NULL, NULL); | ||
| ck_assert_msg(master_tests[i].failure_type == tr_rtype(tr), | ||
| "Failure type wrong for test %d:%s:%s", |
There was a problem hiding this comment.
I'm confused what is going on here. Are the tabs being replaced with spaces, or only some of the tabs?
There was a problem hiding this comment.
GNU Emacs (default) auto-indentation, I will replace tabs by spaces.
1 participant
#100