Skip to content

Get macOS workflows working again#376

Merged
eschaton merged 7 commits into
libcheck:masterfrom
eschaton:eschaton/fix-osx-workflows
Jul 2, 2026
Merged

Get macOS workflows working again#376
eschaton merged 7 commits into
libcheck:masterfrom
eschaton:eschaton/fix-osx-workflows

Conversation

@eschaton

@eschaton eschaton commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

I'm using this PR to try to get macOS workflows working. I expect this will require a combination of adjustment to the workflows themselves as well as to the configure.ac file to modernize both.

@eschaton

eschaton commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

Looks like the only remaining issue is that processing check.texi is generating errors that aren't generated on Linux.

@brarcher

brarcher commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I see the same check.texi issues in the windows builds too. I'm thinking the version of texinfo tool used in the Linux tests is more forgiving of errors.

I've updated check.text to pass, and fixed the other issues with the windows tests. That's now merged into master. Feel free to rebase to pick up those changes and confirm that all the osx issues are resolved.

@eschaton

eschaton commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

Excellent, thanks! Hopefully just a little more poking at it and it'll all work!

@eschaton eschaton force-pushed the eschaton/fix-osx-workflows branch from fa5b2cb to fe19937 Compare July 2, 2026 04:02
@eschaton eschaton force-pushed the eschaton/fix-osx-workflows branch from fe19937 to 8a5e9e6 Compare July 2, 2026 04:06
@eschaton

eschaton commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

OK, now we're down to only build_osx_cmake failing. That should be tractable.

@eschaton

eschaton commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator Author

@brarcher Where is HAVE_SETITIMER supposed to come from in a CMake build? It's not being set and the #else in both timer_{delete,settime} is missing a return 0; which can cause the call to return an error, not 0.

Since `cmake/config.h.in` gets filled in by calls to
`check_function_exists()` within `CMakeLists.txt`, it needs an entry
for `HAVE_SETITIMER` in order for it to propagate to the generated
`config.h` file.
@eschaton eschaton marked this pull request as draft July 2, 2026 05:06
@eschaton eschaton changed the title WIP: Experimental PR on which to try to get macOS workflows working Get macOS workflows working again Jul 2, 2026
@eschaton eschaton marked this pull request as ready for review July 2, 2026 05:07
@eschaton eschaton merged commit 54a33a1 into libcheck:master Jul 2, 2026
23 checks passed
@eschaton eschaton deleted the eschaton/fix-osx-workflows branch July 2, 2026 05:13
@brarcher

brarcher commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Where is HAVE_SETITIMER supposed to come from in a CMake build? It's not being set and the #else in both timer_{delete,settime} is missing a return 0; which can cause the call to return an error, not 0.

Thanks for catching that (I missed the return when fixing the windows builds earlier).
I see you also figured out where the HAVE_SETITIMER should go for cmake.

Thanks for resolving the osx builds! Now the builds are back to green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants