Update window workflow#377
Merged
Merged
Conversation
Github announced in 2026 that the 2026 version of Visual Studio is now available. Switching to that version, as the previous version used in the workflow from 2019 is no longer available.
The msys2 installation used on the windows vms don't have autotools installed like they did previously. To fix, the package manager for msys2 will be used to install autotools first: https://packages.msys2.org/packages/autoconf-wrapper
The pacman tool needs the --noconfirm flag so it doesn't ask for user confirmation.
The project config in github expects it to be called vs16. Technically the name is now out of date. However, I'm aiming to get the tests working for now, and don't want to also update the workflow names too.
It was already being checked later on
In updating the tests for windows to start passing, It was observed that one of the tests for msys2 in cmake are now failing: test_ck_assert_ldouble_eq in check_check_sub.c The test is expected to fail with the following message: Assertion 'x == y' failed: x == 1.1, y == 1.2 However, it’s actually failing with: Assertion 'x == y' failed: x == 2.42347e-312, y == 2.42347e-312 The other platforms being tested are getting the expected error message. It’s not clear what’s wrong with msys2 using cmake. Msys2 and autotools gets the expected result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows workflow hasn't been updated in a while, and some of the tool versions aren't available
on the windows vms anymore. Updating the workflow to use more recent tools.