Repository navigation
Conversation
Running bare `pytest` failed to collect tests/test_public_release.py with "No module named 'scripts'", because unlike `python -m pytest` it does not put the working directory on sys.path. Setting pythonpath = . makes both invocations behave the same.
Collaborator
|
Thanks for the contribution. Closing this PR as we don’t plan to make this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running the test suite with plain
pytest(rather thanpython -m pytest) fails during collection:python -m pytestputs the current directory onsys.path; thepytestentry point does not, sofrom scripts.check_public_release import ...can't be resolved.Change
Add
pythonpath = .topytest.iniso both invocations behave the same. The option is available since pytest 7.0, which matches the existingpytest>=7,<10pin inrequirements-dev.txt. No code or dependency changes.Verification
On Python 3.11 with
requirements-dev.txtinstalled:pytest -q tests/test_public_release.py→ collection error above.pytest -q→ 217 passed, 2 skipped.python -m pytest -q→ 217 passed, 2 skipped (unchanged).python scripts/check_public_release.pypasses.No changelog entry since this only affects running the tests locally.