Skip to content

Conversation

@siva-portworx
Copy link
Contributor

What type of PR is this?

Uncomment only one and also add the corresponding label in the PR:
bug
feature
improvement
cleanup
api-change
design
documentation
failing-test
unit-test
integration-test

What this PR does / why we need it:

Does this PR change a user-facing CRD or CLI?:

Is a release note needed?:

Issue:
User Impact:
Resolution

Does this change need to be cherry-picked to a release branch?:

Diptiranjan and others added 30 commits February 15, 2023 16:33
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
* Added test for Clone PVCs after DR on destination cluster

* Added test for Clone PVCs after DR on dest cluster

* modified test to chec pvc bound

* modified test to check pvc bound

* Addressed review comments

* Added changes to use storageclassName instead of storage class in annotations for clone pvc test

---------

Co-authored-by: root <root@geet-test-source-1.cluster.local>
Co-authored-by: GEET JAIN <getjain@purestorage.com>
Co-authored-by: geet <geet@DevBox.myguest.virtualbox.org>
Co-authored-by: root <root@crdtest-4.cluster.local>
Co-authored-by: Rohit-PX <32072909+Rohit-PX@users.noreply.github.com>
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
- added NFS type to stork v1alpha1 APIs
- added objectlock specific API for for NFS
- skipped bucket exist check in Application backup
  controller specifically for NFS scenario

Signed-off-by: Lalatendu Das <ldas@purestorage.com>
(cherry picked from commit 0b38680)
…cation restore controller.

(cherry picked from commit 38e6416)
…pplicationbackup controller code to utils pkg

(cherry picked from commit f477b06)
If the backuplocation type is NFS then we will take a Generic backup for
any type volume.

Signed-off-by: Lalatendu Das <ldas@purestorage.com>
(cherry picked from commit d2ff8da)
…paces to avoid compilation error

(cherry picked from commit 6a65494)
- NFS vol restore support
- Support for creating restore pvc using nfs executor job
- Trigerring kdmp restore after pvc creation for vol restore

(cherry picked from commit 680ba0c)
sivakumar subramani and others added 28 commits February 15, 2023 16:37
… activate only and false as part of stockctl deactivate.
* PB-3397: Add Logic to support namespace label selector in the application backup controller
	- These feature is supported with manual and schedule backups
	- Currently Namespaces come along the application backup spec consider to be backed up,
	  Now these namespaces are selected using the namespace selectors provided as part of the same spec at execution time.
	- Filtered namespaces that to be backed up are also updated to the data-store object while reconciling.
	- Conveerted come of the data structure and variable to public,
	  so that it can be used in kdmp nfs executor job.
	- snapshot.json will be uploaded in nfs executor, if
	  backuplocation is nfs type.
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit f081953)
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit e56b6b7)
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit e6352d7)
…eRancherProjectDetails.

(cherry picked from commit 6e3d638)
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
(cherry picked from commit ada6658)
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
(cherry picked from commit 22571fd)
… for rancher

Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit 90da8c7)
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit a169e05)
* PWX-28751: Update service on secondary cluster with update on primary

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>

* PWX-28751: Merge secrets and update AutomountServiceAccountToken on secondary cluster.

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>

---------

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
(cherry picked from commit d5b58ae)
)

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
Co-authored-by: Rohit-PX <32072909+Rohit-PX@users.noreply.github.com>
(cherry picked from commit b147963)
…r namespace selector.

(cherry picked from commit afbb4b3)
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
(cherry picked from commit 8e2ffaf)
… map to the string

Signed-off-by: Santosh Kumar Gajawada <sgajawada@purestorage.com>
(cherry picked from commit 02ed11c)
This commit is to bring namespace label's string flavoured namespace list
function.

Signed-off-by: Lalatendu Das <ldas@purestorage.com>
* PWX-29068: Improving storkctl create clusterpair help output.

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>

* Moving (currently supported only for Rancher) to the top

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>

---------

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit 33dbeea)
Signed-off-by: Kesavan Thiruvenkadasamy <kthiruvenkadasamy@purestorage.com>
(cherry picked from commit b157feb)
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

❌ Patch coverage is 61.90476% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.95%. Comparing base (660356d) to head (ac904c3).
⚠️ Report is 496 commits behind head on master.

Files with missing lines Patch % Lines
pkg/storkctl/migration.go 51.61% 23 Missing and 7 partials ⚠️
pkg/storkctl/clusterpair.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   68.15%   67.95%   -0.20%     
==========================================
  Files          42       42              
  Lines        4820     4875      +55     
==========================================
+ Hits         3285     3313      +28     
- Misses       1212     1232      +20     
- Partials      323      330       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.