Skip to content

Update Transform resources to accept array index in the path #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sgajawada-px wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Update Transform resources to accept array index in the path #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ffea69
v1
sgajawada-px Oct 11, 2023
29c4a5b
v2
sgajawada-px Oct 11, 2023
eedd87d
v3
sgajawada-px Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 52 additions & 48 deletions pkg/migration/controllers/resourcetransformation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"reflect"
"regexp"
"strings"

"github.com/libopenstorage/stork/drivers/volume"
Expand All @@ -30,6 +31,8 @@ import (
"sigs.k8s.io/controller-runtime/pkg/reconcile"
)

var pathRegexp = regexp.MustCompile(`^([a-zA-Z_/][a-zA-Z0-9_/]*(\[[0-9]+\])?\.)*[a-zA-Z_/][a-zA-Z0-9_/]*$`)

const (
// ResourceTransformationControllerName of resource transformation CR handler
ResourceTransformationControllerName = "resource-transformation-controller"
Expand Down Expand Up @@ -173,6 +176,9 @@ func (r *ResourceTransformationController) validateSpecPath(transform *stork_api
path.Type == stork_api.KeyPairResourceType) {
return fmt.Errorf("unsupported type for resource %s, path %s, type: %s", kind, path.Path, path.Type)
}
if !pathRegexp.MatchString(path.Path) {
return fmt.Errorf("invalid path for resource %s, path %s, type: %s", kind, path.Path, path.Type)
}
}
}
log.TransformLog(transform).Infof("validated paths ")
Expand Down Expand Up @@ -242,6 +248,7 @@ func (r *ResourceTransformationController) validateTransformResource(ctx context
false,
resourceCollectorOpts,
)
logrus.Debugf("Objects %v", objects)
if err != nil {
r.recorder.Event(transform,
v1.EventTypeWarning,
Expand All @@ -250,57 +257,54 @@ func (r *ResourceTransformationController) validateTransformResource(ctx context
log.TransformLog(transform).Errorf("Error getting resources kind:%s, err: %v", kind, err)
return err
}
for _, path := range spec.Paths {
// This can be handle by CRD validation- v1 version crd support
if !(path.Operation == stork_api.AddResourcePath || path.Operation == stork_api.DeleteResourcePath ||
path.Operation == stork_api.ModifyResourcePathValue) {
return fmt.Errorf("unsupported operation type for given path : %s", path.Operation)
for _, object := range objects.Items {
logrus.Debugf("Objects Item %v", object)

metadata, err := meta.Accessor(object)
if err != nil {
log.TransformLog(transform).Errorf("Unable to read metadata for resource %v, err: %v", kind, err)
return err
}
resInfo := &stork_api.TransformResourceInfo{
Name: metadata.GetName(),
Namespace: metadata.GetNamespace(),
GroupVersionKind: metav1.GroupVersionKind(object.GetObjectKind().GroupVersionKind()),
Specs: spec,
}
logrus.Debugf("resInfo %v", resInfo)
if err := resourcecollector.TransformResources(object, []stork_api.TransformResourceInfo{*resInfo}, metadata.GetName(), metadata.GetNamespace()); err != nil {
log.TransformLog(transform).Errorf("Unable to transform resource: %s/%s having gvk:%v with error: %v", resInfo.Namespace, resInfo.Name, resInfo.GroupVersionKind, err)
resInfo.Status = stork_api.ResourceTransformationStatusFailed
resInfo.Reason = err.Error()
return err
}
for _, object := range objects.Items {
metadata, err := meta.Accessor(object)
if err != nil {
log.TransformLog(transform).Errorf("Unable to read metadata for resource %v, err: %v", kind, err)
return err
}
resInfo := &stork_api.TransformResourceInfo{
Name: metadata.GetName(),
Namespace: metadata.GetNamespace(),
GroupVersionKind: metav1.GroupVersionKind(object.GetObjectKind().GroupVersionKind()),
Specs: spec,
}
if err := resourcecollector.TransformResources(object, []stork_api.TransformResourceInfo{*resInfo}, metadata.GetName(), metadata.GetNamespace()); err != nil {
log.TransformLog(transform).Errorf("Unable to apply patch path %s during validation on resource kind : %s/,%s/%s, err: %v", path, kind, resInfo.Namespace, resInfo.Name, err)
resInfo.Status = stork_api.ResourceTransformationStatusFailed
resInfo.Reason = err.Error()
return err
}
unstructured, ok := object.(*unstructured.Unstructured)
if !ok {
return fmt.Errorf("unable to cast object to unstructured: %v", object)
}
resource := &metav1.APIResource{
Name: strings.ToLower(ruleset.Pluralize(strings.ToLower(kind))),
Namespaced: len(metadata.GetNamespace()) > 0,
}
dynamicClient := localInterface.Resource(
object.GetObjectKind().GroupVersionKind().GroupVersion().WithResource(resource.Name)).Namespace(getTransformNamespace(transform.Namespace))
unstructured, ok := object.(*unstructured.Unstructured)
if !ok {
return fmt.Errorf("unable to cast object to unstructured: %v", object)
}
resource := &metav1.APIResource{
Name: strings.ToLower(ruleset.Pluralize(strings.ToLower(kind))),
Namespaced: len(metadata.GetNamespace()) > 0,
}
dynamicClient := localInterface.Resource(
object.GetObjectKind().GroupVersionKind().GroupVersion().WithResource(resource.Name)).Namespace(getTransformNamespace(transform.Namespace))

unstructured.SetNamespace(getTransformNamespace(transform.Namespace))
log.TransformLog(transform).Infof("Applying object %s, %s",
object.GetObjectKind().GroupVersionKind().Kind,
metadata.GetName())
_, err = dynamicClient.Create(context.TODO(), unstructured, metav1.CreateOptions{DryRun: []string{"All"}})
if err != nil {
log.TransformLog(transform).Errorf("Unable to apply patch path %s on resource kind: %s/,%s/%s, err: %v", path, kind, resInfo.Namespace, resInfo.Name, err)
resInfo.Status = stork_api.ResourceTransformationStatusFailed
resInfo.Reason = err.Error()
} else {
log.TransformLog(transform).Infof("Applied patch path %s on resource kind: %s/,%s/%s", path, kind, resInfo.Namespace, resInfo.Name)
resInfo.Status = stork_api.ResourceTransformationStatusReady
resInfo.Reason = ""
}
transform.Status.Resources = append(transform.Status.Resources, resInfo)
unstructured.SetNamespace(getTransformNamespace(transform.Namespace))
log.TransformLog(transform).Infof("Applying object %s, %s",
object.GetObjectKind().GroupVersionKind().Kind,
metadata.GetName())
_, err = dynamicClient.Create(context.TODO(), unstructured, metav1.CreateOptions{DryRun: []string{"All"}})
if err != nil {
log.TransformLog(transform).Errorf("Error while dryrun of resource: %s/%s having gvk:%v with error: %v", resInfo.Namespace, resInfo.Name, resInfo.GroupVersionKind, err)
resInfo.Status = stork_api.ResourceTransformationStatusFailed
resInfo.Reason = err.Error()
} else {
log.TransformLog(transform).Infof("DryRun is successfull for resource: %s/%s having gvk:%v ", resInfo.Namespace, resInfo.Name, resInfo.GroupVersionKind)
resInfo.Status = stork_api.ResourceTransformationStatusReady
resInfo.Reason = ""
}
logrus.Debugf("resInfo %v", resInfo)
transform.Status.Resources = append(transform.Status.Resources, resInfo)
}
}

Expand Down
Loading