fix(autonatv2): honor forced reachability#3527
Open
pengqima wants to merge 1 commit into
Open
Conversation
Signed-off-by: pengqima <pengqima@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make AutoNAT v2 honor the existing
ForceReachabilityPublicandForceReachabilityPrivateoptions.This change:
WithReachabilityoption;Fixes #3515.
Root cause
The top-level forced reachability value was only passed to AutoNAT v1.
When AutoNAT v2 was enabled, the basic host also used its per-address reachability tracker. That tracker never received the configured override, so addresses could remain unknown or be classified by automatic dial-back checks even though the host had explicitly been forced private or public.
Behavior after this change
When forced reachability is configured, AutoNAT v2 reports that fixed status for local address checks. AutoNAT v2 server functionality remains enabled for remote peers.
Existing behavior is unchanged when no reachability override is configured.
Testing