This repository was archived by the owner on Jun 19, 2023. It is now read-only.
SDP munging#10
Merged
Merged
Conversation
John-LittleBearLabs
marked this pull request as ready for review
August 10, 2022 18:32
| "@libp2p/interfaces": "^3.0.3", | ||
| "@libp2p/logger": "^2.0.0", | ||
| "@libp2p/peer-id": "^1.1.15", | ||
| "@multiformats/multiaddr": "../js-multiaddr/", |
Contributor
Author
There was a problem hiding this comment.
Watch out for this. It expects that repo to be there on your local drive, and on my branch.
TODO:
- once feat: add support for webrtc and certhash (#261) multiformats/js-multiaddr#262 has landed, change this to refer to that repo.
- once that change has made it into a release, turn this back into a normal version number requirement
ckousik
approved these changes
Aug 11, 2022
17 tasks
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simplistic replacement, shoving the certhash from the multiaddr into the SDP.