test: validate go-libp2p p2pd download fix on macos-26#3559
Closed
tabcat wants to merge 2 commits into
Closed
Conversation
Reverts the macos-15 pin to macos-latest and overrides go-libp2p to the fixed branch to check the p2pd download works on macos-26. Do not merge.
Member
Author
|
works. closing this one. once libp2p/npm-go-libp2p#94 is merged we can change the ci back to use macos-latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test only, do not merge.
Validates the go-libp2p p2pd download fix (keep
postinstall+ on-first-use fallback +gotinstead of the globalfetch) on the macos-26 runner before opening the npm-go-libp2p PR.macos-latestsotest-noderuns on macos-26.go-libp2pto the fixed branch (github:tabcat/npm-go-libp2p#fix/download-on-first-use), which also forces a node_modules cache miss so p2pd is freshly downloaded on macos-26.Success = the macOS
test-nodeinstall step (cache-node-modules) no longer stalls. Mirrors ipfs/ipfs-desktop#3180's validation of ipfs/npm-kubo#83.