fix(floodsub): apply decode limits and clean up the topic map#3568
Merged
Conversation
Passes configurable decode limits to the inbound RPC decoder and drops the unused gossipsub control block from the wire proto so it is skipped rather than decoded. Closes the peer when its inbound stream errors instead of leaving it half-open, and removes empty peer sets from the topic map on unsubscribe, peer removal and stop.
tabcat
marked this pull request as ready for review
July 16, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@libp2p/floodsubnow bounds how many elements a single inbound RPC frame decodes into, and tidies up some peer/topic bookkeeping.decodeRpcLimitsoption (defaulting to 5000 subscriptions and 5000 messages per frame), so the number of elements decoded from one frame is bounded. This uses@libp2p/utilspbStream's decode-options support.ControlMessage(field 3), which floodsub never reads. It is removed (the field is reserved), so an inbound control block is skipped as an unknown field rather than decoded and discarded.stop(), matching@libp2p/gossipsub.Change checklist