fix(gossipsub): validate the message key for all peer id types#3569
Open
tabcat wants to merge 1 commit into
Open
fix(gossipsub): validate the message key for all peer id types#3569tabcat wants to merge 1 commit into
tabcat wants to merge 1 commit into
Conversation
The message key was checked against the from peer id by comparing public keys directly, which only applies to peer ids that inline their public key. It now derives the peer id from the key and compares that, so the check applies to every peer id type.
tabcat
marked this pull request as ready for review
July 16, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When validating a
StrictSignmessage that carries akey,@libp2p/gossipsubchecks that key against the message'sfrompeer id. That check compared the public keys directly, which only applies when thefrompeer id inlines its public key (Ed25519, secp256k1).It now derives the peer id from the supplied key and compares that instead, so the check applies to every peer id type, including those that don't inline a public key (RSA).
Change checklist