fix(floodsub): bind the message key to the author peer id#3575
Merged
Conversation
StrictSign validation did not verify that a supplied message key corresponds to the `from` peer id when `from` inlines its public key (Ed25519, secp256k1). Bind the key to the author for all peer id types.
tabcat
marked this pull request as ready for review
July 18, 2026 00:07
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under the
StrictSignsignature policy,messagePublicKeyreturned the publickey from a message's
keyfield without checking that it corresponds to themessage's
frompeer id. Whenfromcarries its own public key (Ed25519,secp256k1), that key is authoritative and should be used instead.
Prefer
from's own public key when it is present, and otherwise require thesupplied key to derive to
from, so a signed message is always verified againstthe key its
frompeer id commits to.@libp2p/gossipsubperforms theequivalent check.
Change checklist