Skip to content

fix(config): stabilize working dir and temp dir resolution#348

Merged
genedna merged 2 commits into
libra-tools:mainfrom
marshawcoco:split/workingdir-tmpdir
Apr 12, 2026
Merged

fix(config): stabilize working dir and temp dir resolution#348
genedna merged 2 commits into
libra-tools:mainfrom
marshawcoco:split/workingdir-tmpdir

Conversation

@marshawcoco

Copy link
Copy Markdown
Contributor

Summary

  • make explicit-db config resolution independent from the current working directory
  • harden temp dir and vault path handling used by cloud/fetch flows
  • keep the extraction limited to the working-dir/tmp-dir fixes requested in review

Test plan

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72dcfbf372

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/main.rs Outdated
Comment thread src/command/rev_parse.rs Outdated
Comment thread src/internal/tui/diff.rs Outdated
Extract the working-directory and tmp-dir fixes into a standalone change so they can land before the rev-parse and rev-list commands.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marshawcoco
marshawcoco force-pushed the split/workingdir-tmpdir branch from 72dcfbf to 6b132b5 Compare April 10, 2026 06:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b132b5fb2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/command/fetch.rs Outdated
Use USERPROFILE before HOME when resolving the vault SSH temp directory on Windows so MSYS-style HOME paths do not redirect temp key material to the wrong location.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@genedna
genedna merged commit bba8207 into libra-tools:main Apr 12, 2026
7 checks passed
@marshawcoco
marshawcoco deleted the split/workingdir-tmpdir branch April 13, 2026 07:15
@marshawcoco
marshawcoco restored the split/workingdir-tmpdir branch April 13, 2026 07:15
@marshawcoco
marshawcoco deleted the split/workingdir-tmpdir branch April 13, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants