Repository navigation
3.0.1: plan the destroy file that Invoke-LdoTerraformDestroy applies - #1
Merged
Merged
Conversation
Invoke-LdoTerraformPlanDestroy wrote tfplan.plan.destroy by default while Invoke-LdoTerraformDestroy applied tfplan-destroy.plan, so the pair called with their defaults (as every Libre DevOps module's just destroy does) planned one file and then failed to find it. PlanDestroy now defaults to tfplan-destroy.plan, and a Pester test keeps the two defaults equal.
…pull request build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Invoke-LdoTerraformPlanDestroynow defaults-PlanFiletotfplan-destroy.plan, the fileInvoke-LdoTerraformDestroyapplies by default.Why
They disagreed (
tfplan.plan.destroyagainsttfplan-destroy.plan), so the pair called with their defaults planned one file and then failed to find it. Every Libre DevOps module'sjust destroycalls them that way.Notes
-PlanFileon both is unaffected.Tests
New Pester test
Destroy plan file defaultsreads both commands' parameter defaults and requires them equal.tests/Terraform.Tests.ps1: 24 passed; PSScriptAnalyzer clean on the Terraform module.