Repository navigation
4.5.0: leave the trigger's caller IP list out unless allowed_ips is set - #2
Merged
Merged
Conversation
access_control.trigger.allowed_ips now defaults to null, and the module writes allowedCallerIpAddresses only when it is set. Before, the [] default was always written, and Logic Apps reads an empty list as "other Logic Apps only": a trigger configured with only an authorization policy shut out every token-bearing caller (AuthorizationFailed ... not in the allowed caller IP address ranges, proven live), and the only way round it was 0.0.0.0/0. An explicit [] is still written as it is, so a caller who meant Logic Apps only keeps it. The complete example drops its wide allow, which the default now gives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
access_control.trigger.allowed_ipsnow defaults tonull, andallowedCallerIpAddressesis written only when it is set.Why
The old
[]default was always written, and Logic Apps reads an empty list as "other Logic Apps only". A trigger with only an authorization policy therefore shut out every token-bearing caller (AuthorizationFailed ... not in the allowed caller IP address ranges, proven live in the device intake lab), and the only workaround was0.0.0.0/0.Behaviour change
allowed_ips(the default) now means no caller IP list: any address may call, and the token or SAS is the gate. Before, it meant Logic Apps only.allowed_ips = []explicitly.[], is written as before.Tests
New run
trigger_ips_unset_are_omitted_and_empty_is_kept: with policies and noallowed_ipsno list is written; an explicit[]is kept. 43 runs pass.