Skip to content

[agent] fix(subagents): require progress evidence and support reconciled task recovery - #179

Closed
thisisjun786 wants to merge 7 commits into
lidge-jun:devfrom
thisisjun786:codex/subagent-retirement
Closed

thisisjun786 wants to merge 7 commits into
lidge-jun:devfrom
thisisjun786:codex/subagent-retirement

Conversation

@thisisjun786

@thisisjun786 thisisjun786 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Closes #178.

An executor can keep investigating while its working tree stays clean. The old waiting guidance treated repeated empty waits as failure. It also lacked an executable recovery path when a child stopped after confirmed stagnation or unusable output without a provider error.

The waiting reference now requires meaningful progress comparisons and a delivered checkpoint before declaring stagnation. It distinguishes missing visibility, final-output failure, cancellation, and resource limits, and requires prior work to stop before handoff.

Managed dispatch adds outcome: "task_failed" for confirmed stagnation or unusable_output. It validates bounded evidence, the recorded child ID, stopped execution, and reconciliation before reusing the existing two-attempt handoff. A returned ready still requires a fresh claim; only main-direct permits main to reclaim work. Provider error precedence and terminal stop decisions remain intact. The CLI guidance, plan template, architect recovery clause, public guide, and doctrine agree on these permissions.

Verification for cb25e3b1:

  • Build: 181 files compiled and layout validated; generated output matches source.
  • Full root suite: 3,165 total, 3,091 passed, 74 skipped, 0 failed. Locked dependencies and an isolated TMPDIR resolved local environment failures without product changes.
  • Focused dispatch and separate-process CLI regressions: 38 passed, 0 failed; the original task-failure regression was observed failing before implementation.
  • Real compiled root CLI: 35 captured invocations covering recovery, persistence, duplicate claims, invalid evidence, live children, and stop precedence.
  • Gate, inventory, and whitespace checks passed. Independent source and final-record reviews found no substantive issues.
  • Linux, Windows, and macOS CI passed. Automatic GitHub code review completed on this head with no new findings; all four earlier review threads are resolved. The separate package and install checks also passed on every configured platform.

Progress classification and child-shutdown evidence remain main-agent judgments; this does not add a runtime watchdog or authenticated termination receipts. No plugin installation, merge, or release is part of this PR.

Verification record.

@github-actions github-actions Bot added the bug Something isn't working label Sep 14, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T08:52:29.686423Z cb25e3b New commits
🔒 Security Review Completed 2026-09-14T20:18:52.883870Z 3767ae8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3767ae8826

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread structure/20_pabcd_dispatch_doctrine.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a829dfe95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread structure/20_pabcd_dispatch_doctrine.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c0bcc6f71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/codexclaw/skills/loop/references/waiting.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20e50485f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/codexclaw/skills/loop/references/waiting.md
@thisisjun786 thisisjun786 changed the title fix(delegation): require progress evidence before retiring subagents [agent] fix(subagents): require progress evidence and support reconciled task recovery Sep 15, 2026
@thisisjun786

thisisjun786 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #180. The replacement retains this PR's evidence-based retirement guidance, explicit task-failure recovery and resolved review fixes. Its recovery runtime is carried unchanged.

The combined change strengthens architect consultation while preserving CXC's existing delegation-selection rules and independent review. Live-child reconciliation and stop rules still apply. This PR is closed in favor of the single replacement; the original branch and contribution history remain preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant