-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(devlog): verify the Kiro quota and pool phases compose on dev #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
devlog/_plan/260829_kiro_quota_pool/110_integrated_verification.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # 110 — Integrated verification on dev | ||
|
|
||
| Three PRs landed separately, so the last thing worth proving is that they compose. | ||
| Verified against `origin/dev` at `3e3df05aa`, which contains all three plus unrelated | ||
| work merged in between (`6703aba88`, `b9cb23656`). | ||
|
|
||
| ## What is on dev | ||
|
|
||
| | PR | Merge | What it delivered | | ||
| | --- | --- | --- | | ||
| | [#2875](https://github.com/lidge-jun/opencodex/pull/2875) | `d82b3049d` | Kiro usage reader, per-account + provider quota, quota-aware 429 recovery, CLI column, docs | | ||
| | [#2878](https://github.com/lidge-jun/opencodex/pull/2878) | `12fbb5b7a` | Pre-dispatch account selection | | ||
| | [#2880](https://github.com/lidge-jun/opencodex/pull/2880) | `3e3df05aa` | Quota persistence across restart | | ||
|
|
||
| ## Result | ||
|
|
||
| ```text | ||
| bun x tsc --noEmit -> exit 0 | ||
| bun test (9 files) -> 259 pass / 0 fail / 756 expect() calls | ||
| ``` | ||
|
|
||
| Files: `kiro-usage-quota`, `kiro-account-quota`, `kiro-pool-rank`, | ||
| `provider-account-quota-persistence`, `provider-account-quota`, `provider-quota`, | ||
| `generic-oauth-failover`, `cli-headless-parity`, `core-lab-boundary`. | ||
|
|
||
| The last of those matters independently: none of this work put a Lab import on the | ||
| request path, which the boundary walker verifies transitively rather than by inspection. | ||
|
|
||
| ## Known unrelated failures | ||
|
|
||
| `bun run test` reports three failures in | ||
| `tests/codex-envkey-admission-substitution.test.ts`. They reproduce on unmodified | ||
| `124a2b148` in a separate clean worktree, so they predate this unit and are not caused | ||
| by it. | ||
|
|
||
| ## Objective status | ||
|
|
||
| - **Kiro quota display** — done. Per-account and provider rows, GUI bars, CLI column, | ||
| explicit unknown state. | ||
| - **Pool-based automatic loading** — done in both directions: quota-ranked selection | ||
| before the first request, and quota-ranked rotation after a 429, with exhaustion | ||
| cooldowns and per-account credential/route pairing. | ||
| - **429 PR reconciliation** — done in doc `003`: seven merged, two superseded by #2841, | ||
| nothing needing rework. #2783 is a separate open unit. | ||
|
|
||
| What remains kiro-lb's, honestly: an operations dashboard and dashboard-native device | ||
| login. Both are product surface, not pool machinery. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_finThis close-out says the objectives are complete and the only remaining items are outside the unit's scope, but the commit leaves the entire unit under
devlog/_plan/260829_kiro_quota_pool/. That misclassifies finished work as an open unit and also skips the move explicitly required by050_verification_and_delivery.md; move the directory todevlog/_fin/as part of this close-out.AGENTS.md reference: AGENTS.md:L83-L86
Useful? React with 👍 / 👎.