-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(devlog): close the remote hub restack unit #3162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # 150 — 유닛 종료 | ||
|
|
||
| 리모트 허브 재스택 유닛을 닫는다. `dev` HEAD `75d9ada92`. | ||
|
|
||
| ## 랜딩 총계 | ||
|
|
||
| 열두 건이 머지됐고 한 건을 중복으로 닫았다. | ||
|
|
||
| - 스택 7단계: #2771 #2772 #2776 #2777 #2781 #2786 #2789 | ||
| - `dev` 플레이크 근본 수정: #3147 | ||
| - 문서: #3149 #3159 #3160 #3161 | ||
| - 중복 정리: #3143 (CLOSED) | ||
|
|
||
| ## 남은 것 | ||
|
|
||
| **#3158** — P2 4건(T2 인증된 models 경로, T3 관리 ingress GUI health, | ||
| T19 readiness 문서화, T21 config 키 문서화)과 `shutdown-launcher` SIGINT | ||
| 워치독 플레이크. | ||
|
|
||
| ## 이 유닛이 남긴 판단 두 개 | ||
|
|
||
| **리뷰 지적을 검증 없이 반영하지 않는다.** #3147의 P1은 인과가 뒤집혀 있었고 | ||
| (`auth-api.ts:1332-1335`에서 `dev`도 이미 stale, WHAM은 리다이렉트 경로 밖), | ||
| 그대로 받아 적었다면 없는 레이스를 수정 이력에 남길 뻔했다. 반대로 #3149의 | ||
| 네 지적은 전부 사실이었다. 구분하는 방법은 매번 코드를 보는 것뿐이다. | ||
|
|
||
| **공개 순서는 코드 순서와 별개 제약이다.** 문서가 미수정 취약점의 재현 조건을 | ||
| 담고 있으면, 그 문서의 머지는 수정의 머지 이후여야 한다. `AGENTS.md`의 | ||
| "이미 공개 diff가 드러냈는가" 기준은 파일 내용이 아니라 순서에 걸린다. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file explicitly declares the unit closed, but adding the closeout under
devlog/_plan/260901_remote_hub_restack/leaves the entire completed unit classified as open. Move the unit directory todevlog/_fin/260901_remote_hub_restack/when recording this terminal outcome.AGENTS.md reference: AGENTS.md:L83-L86
Useful? React with 👍 / 👎.