-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(catalog): preserve captured discovery authority with agy aliases (carry of #3531) #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5676a80
fd7fd9a
4256af0
646d720
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -218,6 +218,7 @@ export function providerConfigSeed(entry: ProviderRegistryEntry): OcxProviderCon | |
| baseUrl: entry.baseUrl, | ||
| ...(entry.apiKeyTransport !== undefined ? { apiKeyTransport: entry.apiKeyTransport } : {}), | ||
| ...(entry.responsesPath ? { responsesPath: entry.responsesPath } : {}), | ||
| ...(entry.alias ? { alias: entry.alias } : {}), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For the normal Google Antigravity OAuth flow, Useful? React with 👍 / 👎. |
||
| // Preserve the registry auth kind verbatim (including "local") so fail-closed gates that | ||
| // distinguish local runtimes from API-key providers keep working after the seed round-trip. | ||
| authMode: entry.authKind, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a valid custom provider is named
agyalongside an unaliasedgoogle-antigravityprovider, this check ignores that provider key and still labels Google's catalog rows asagy/<model>. Insrc/router.ts, the exacthasOwnProvider(config.providers, requestedProvider)lookup runs before alias resolution, so selecting that advertised row silently routes the Google model ID through the customagyprovider. Treat other configured provider names as alias claims here, not only theiraliasfields.Useful? React with 👍 / 👎.