-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test(state): isolate shutdown fallback from host clock delays #3755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+33
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
devlog/_plan/260906_release_244_followups/052_shutdown_fixture.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Shutdown fallback fixture clock | ||
|
|
||
| CI34021352755 on the documentation-only combo closeout failed one macOS test: | ||
| shutdown drain cap expiry enters the synchronous spill fallback. The run had | ||
| 10,050 passes and one failure. This file and production state.ts were unchanged | ||
| from the previously green e1f5a5b8d runtime. | ||
|
|
||
| The fixture freezes ACL and spill clocks but the shutdown reserve uses Date.now. | ||
| An 80 ms reserve therefore still races host disk/scheduling latency (the failure | ||
| was ETIMEDOUT inside fallbackPendingResponseSpills). Freeze that third clock only | ||
| around flush, using the existing spy pattern from the neighboring ordering test. | ||
| The real 40 ms drain timer still expires while the async publication gate stays | ||
| held; positive synchronous-call, empty-pending and installed-stub assertions remain. | ||
| Release the gate, await the publication tail and restore the clock in finally. | ||
|
|
||
| This C1 verifier repair changes one fixture, no production timeout, skip or retry | ||
| policy. Budget-exhaustion/watchdog cases remain untouched. Land as a separate | ||
| prerequisite PR and cascade the combo branch. Independent fixture review and new | ||
| exact parent/child hosted CI are required; no local suite/typecheck/build runs. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Name the
finallyblock explicitly.Replace “restore the clock in finally” with “restore the clock in the
finallyblock.” This matches the cleanup code intests/responses/responses-state.test.tsLines 1448-1449.Suggested wording
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[grammar] ~14-~14: Ensure spelling is correct
Context: ...Release the gate, await the publication tail and restore the clock in finally. This...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~14-~14: Use a hyphen to join words.
Context: ...e publication tail and restore the clock in finally. This C1 verifier repair cha...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Source: Linters/SAST tools