feat(gui): add opt-in Codex Desktop sign-in toggle - #3860
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (15)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe dashboard adds an opt-in Codex Desktop authless setting. It persists the preference, runs synchronization, exposes localized controls, documents requirements, and tests default behavior and sync failures. ChangesCodex Desktop authless setting
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The current implementation and regression tests show no actionable merge-blocking issue. Sequence Diagram(s)sequenceDiagram
participant Dashboard
participant useDashboardData
participant SettingsAPI
participant SyncAPI
Dashboard->>useDashboardData: Toggle authless setting
useDashboardData->>SettingsAPI: Save codexDesktopAuthless
SettingsAPI-->>useDashboardData: Return catalogRefreshPending
useDashboardData->>SyncAPI: Run full sync
SyncAPI-->>useDashboardData: Return success or sync error
useDashboardData-->>Dashboard: Update preference and refresh status
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 14 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. Hygiene✅ Deterministic PR hygiene checks passed. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
리뷰 · 우선순위 56 / 80이 PR은 RobinBially의 원본입니다. Dashboard에 Codex Desktop 로그인 생략 토글을 default-OFF opt-in으로 넣습니다. #3689(default-on 강제)를 대체하는 범위이고, 메인테이너 방향과 맞습니다. 검증도 원본 쪽에서 GUI·주입·전체 스위트를 돌려 두었습니다. 다만 지금은 릴리스 트레인 캐리 #3876이 같은 기능을 권장 처리는 close-don't-rebase가 아니라 carry supersede입니다. #3876이 랜딩되면
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
…e (carry #3860) [skip ci] feat(gui): add default-off Codex Desktop sign-in preference
|
Landed on |
Summary
Add Open Codex without signing in to Dashboard → Overview as an explicit opt-in, default OFF. An absent or false
codexDesktopAuthlesskeeps the existing sign-in requirement; an existing explicit true stays enabled. This replaces #3689 with the scope requested by the maintainer.The toggle uses the existing settings API, saves the preference and runs full sync. Sync errors remain visible without undoing the saved preference. All nine interface languages explain the off default, required upstream credentials, Codex restart and potentially unavailable account-gated Desktop features.
No runtime routing, catalog, authentication-default or provider-label changes. Existing local eligibility, remote admission authentication and user-owned gateway settings are preserved.
Verification
bun run test --parallel=8— 21,129 pass / 16 skip / 0 fail.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
Documentation
Localization