fix(providers): admit larger Nous catalogs within native limits - #3957
Conversation
Carry source fix from e31f5be (#3939) and add isolated gather/probe regressions for 390-row paid/free catalogs. Preserve the 512-row and global byte ceilings. Local product tests, typecheck, build and install NOT RUN per owner instruction; hosted CI verifies this candidate. Co-authored-by: Vocllum <149675937+Vocllum@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Nous provider now permits model-discovery responses up to 1 MiB. Tests cover authenticated probing, 390-model discovery, discovery status, live model counts, caching, and repeated gathers. ChangesNous catalog capacity
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Nous model discovery can reject a valid paid/free catalog above its old 256 KiB response cap. Raise only the Nous cap to 1 MiB while retaining its 512-row limit and the shared 4 MiB ceiling.
Carry #3939 from
e31f5be74af6eb31ad871b22ab09cbace345fdd1, preserving Vocllum. Add isolated synthetic regressions through the real catalog gather and management connection probe: 390 rows above the former cap, expected paid/free IDs, model count, cache publication and reuse. Existing shared overflow/cancellation and raw-row limit tests remain authoritative. No new provider or credential destination is introduced.Verification
711a3f65c5b5c8398b4309955cc20d8002c4c31c.d5778ac8d7failed because the synthetic bearer literals did not match the repository fixture allowance. Four fixture strings were corrected without changing scanner policy; the superseded failing run was cancelled and is not green evidence.caeaf45of this head into514350e6f. Laterdevchange9c54000c9removes historical account captures/notes only; runtime, tests, manifests, lockfiles and build inputs are identical. Whole final-tree identity will be checked against the merge calculation; that is distinct from claiming the final docs combination executed in CI.dev, subject to current-head review/CI and no outstanding maintainer objections. Original author credit must remain in the squash commit.Checklist
Co-authored-by: Vocllum 149675937+Vocllum@users.noreply.github.com
Pre-merge refresh: current dev
01c23aedcdfcb913151a2ac8f7acebda58d91eeeincludes another C documentation/capture cleanup only.git diff --quiet 514350e6f origin/dev -- src tests gui scripts package.json bun.lock tsconfig.json .githubexits 0. No runtime/test/build-input drift.Summary by CodeRabbit
Bug Fixes
Performance