fix(routing): preserve configured provider namespace ownership - #3966
Conversation
(cherry picked from commit 7ad7474) Co-authored-by: luvs01 <luvs01@hanmail.net>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughConfigured provider names now suppress conflicting built-in aliases case-insensitively in catalog generation and routing. Tests cover canonical names, custom namespaces, case variants, and fallback behavior. Reference documentation describes the updated rules in five languages. ChangesProvider namespace alias collision handling
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 71 / 80이 PR은 사용자가 설정한 공급자 이름이 지금 변경은 같은 판정을 두 곳에 대칭으로 넣습니다. 라인 src/providers/default-aliases.ts · claimedByOther - 카탈로그 표시용 별칭 억제입니다. 이름 점유를 alias 점유와 같이 보지 않으면 GUI/카탈로그에 라인 src/router.ts · Pass 2 registryMatches - 라우팅 쪽 같은 판정입니다. 한쪽만 고치면 “목록과 실제 라우트가 다른” 상태가 됩니다. 두 파일 대칭을 유지하세요. 경로 #3935 - 같은 수정의 contributor 원본(open)입니다. 이 carry가 먼저 들어가면 #3935는 landed-via-maintainer로 닫으면 됩니다. 새 공급자나 마이그레이션은 없습니다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
A configured provider named
agyorAgYmust own its namespace. Prevent the built-in Google Antigravity alias from being advertised or selected over that configured name, while retaining existing exact canonical, explicit-alias and unknown-prefix precedence.Carry #3935 from
7ad74746ed260b441ddbceb7a46204085945aa3eonto current dev without modifying the contributor fork. The original two source changes, regression and five-locale documentation are preserved; intervening routed-agent documentation remains intact. This is one bug and one PR.Verification
796f7fe34a3d503bc48b2588413ba2ef73ac8499built 425 documentation pages on remote macmini-cf using Bun 1.4.0 and frozen dependencies; tracked files remained unchanged. No deployment ran.9c8f66b9dadds only independent release-note renderer/scripts and tests after this candidate base. Alias/router source, affected tests and documentation build inputs are unchanged. Candidate CI is not claimed to have executed that later combined release-note tree; final merge-tree equality is checked separately.Checklist
Co-authored-by: luvs01 luvs01@hanmail.net
Summary by CodeRabbit
New Features
Documentation