fix(codex): retry warmup with gpt-5.6-luna on 400 and 404 for ChatGPT Free accounts (#4126) - #4188
Conversation
|
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughCodex account warmup now retries HTTP 404 responses and uses ChangesCodex warmup retry handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Warmup now recovers from documented model-provisioning failures while preserving immediate handling of authentication failures. The supplied regression coverage supports merging with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (8 skipped: 8 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 70 / 80이 PR은 #4126을 직접 고친다. 증상은 ChatGPT Free(특히 당일 생성) 계정에서 OAuth는 성공하는데 Codex 계정 warmup만 HTTP 404로 떨어지고, GUI가 “다시 로그인하라”고 말하는 것이다. 보고자·후속 확인에 따르면 공식 Codex 클라에서는 같은 계정으로 변경은 세 갈래다. (1) 다만 머지 전에 겹치는 축이 있다. 열린 #4144도 라인 - 라인 - 라인 - 경로/심볼 - docs-site 8로케일 경로/심볼 - 라벨·CI — 경로/심볼 - #4144 — 같은 auth/warmup 표면의 열린 PR. 머지 순서·리베이스 합의가 필요하다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Ingwannu
left a comment
There was a problem hiding this comment.
The 404-to-next-model path addresses the reported warmup gap, and stopping on a nonretryable error inside the fallback loop is important now that there is more than one fallback. However, the new 401 test exercises only the primary attempt; that branch already aborted before this change.
Please add a primary 400/404 followed by fallback 401, 429, and 5xx matrix asserting no later model request, plus exhaustion/cancellation controls. These should observe outgoing attempt count and the final typed error, not just a helper predicate. Keep the reporter's successful Luna control distinct from a guarantee that every Free account is entitled to it. The new auth-api diagnostic also needs an assertion through that caller. This is a bounded review comment; required exact-head product CI is not established by the listed focused run.
Summary
gpt-5.4-miniprovisioned or available, returning HTTP 404. Furthermore, the previous sole fallback modelgpt-5.5is rejected as unsupported on Free accounts, whereasgpt-5.6-lunais supported and functions correctly in official Codex clients.gpt-5.6-lunatoFALLBACK_MODELSinsrc/codex/warmup.ts.verifyCodexAccountWarmupinsrc/codex/auth-api.tsto output an accurate, actionable diagnostic message ("Codex account warmup failed. Verify account model access or provisioning and try again.") on HTTP 400 or HTTP 404 instead of misleadingly claiming that re-authentication is required.docs-site/.Closes #4126
Verification
tests/codex-integration/warmup.test.ts:gpt-5.4-mini-> 404 ->gpt-5.5-> 400 ->gpt-5.6-luna-> 200 SSE)./home/ubuntu/.bun/bin/bun test warmup(21 pass, 0 fail, 56 expect calls across 2 test files)/home/ubuntu/.bun/bin/bun run typecheck(strict tsc, 0 errors)/home/ubuntu/.bun/bin/bun run privacy:scan(privacy scan passed)gemini-3.8-flash-high(reasoning_effort="max") verifying boundary safety, timeout cleanup, token privacy, and error classification.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
gpt-5.6-lunaas an additional fallback model.Bug Fixes
Documentation