-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(start): diagnose auxiliary listener failures and malformed edits #4353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
9cab1ae
fix(start): report auxiliary listener failures without public-port re…
lidge-jun c597591
fix(start): retain degraded-listener evidence in salvage diagnostics
lidge-jun d95743b
test(config): activate routing-profile salvage in listener regression
lidge-jun dcd2d07
fix(search): retry clean empty answers without masking truncation
lidge-jun 45f703f
test(search): narrow terminal fixture projection
lidge-jun 3652da7
test(search): exercise live output truncation without duplicate replay
lidge-jun 59ec04b
fix(cursor): preserve first overflow and bound stable-thread remints
lidge-jun 36625c7
test(cursor): activate remint guards after first overflow
lidge-jun 321b9b1
fix(live): validate sideband upstream before client upgrade
lidge-jun e5ce931
fix(config): identify the actual malformed hub field in listener warn…
lidge-jun 46f90d3
Merge latest dev and preserve sideband runtime contract
lidge-jun 7cccab3
fix(dashboard): guide hub pairing without restarting healthy clients
lidge-jun 673ee8c
fix(openai-chat): normalize oversized inline images before serialization
lidge-jun b110d63
fix(openai-chat): retain synchronous under-budget image construction
lidge-jun 1898bba
merge: reconcile current dev documentation for search recovery
lidge-jun 14e93ca
merge: preserve current dev contracts for #4378
lidge-jun 2be548a
merge: preserve current dev contracts for #4353
lidge-jun 06fc280
Merge remote-tracking branch 'origin/dev' into codex/260912-finish-4363
lidge-jun eca7ce9
fix(cursor): preserve isolated recovery state and active cap retention
lidge-jun 8cafec9
Merge remote-tracking branch 'origin/dev' into codex/260912-finish-4367
lidge-jun 3ad908f
docs: synchronize live sideband handshake ownership
lidge-jun efb3936
fix(search): reject malformed truncated calls before replay
lidge-jun 4124a64
fix(dashboard): retain access errors across compound poll failures
lidge-jun 57b3057
docs: describe cancelled live sideband handshakes
lidge-jun 52c8e8a
fix(pairing): use erasable types and explicit JSX event handlers
lidge-jun 3e73ca4
docs: record operations resume and remaining verification
lidge-jun 36ab8cd
fix(opencode): separate local management catalog authority from infer…
lidge-jun 535884e
docs: pin operations final verification and reconciliation scope
lidge-jun c5e9737
merge: reconcile listener candidate with the shared fixture repair ba…
lidge-jun f67d4f0
merge: reconcile pairing candidate with the shared repair baseline
lidge-jun 25c70d5
test(clients): retain bounded phase evidence for coordinator refusal …
lidge-jun c720dc5
test(clients): preserve spawn failures without captured stderr
lidge-jun b4cc99e
[skip ci] chore(stack): merge origin/dev into codex/260912-60plus-str…
lidge-jun 4f260b7
[skip ci] chore(stack): merge codex/260912-60plus-stream-search into …
lidge-jun 37bc1a0
[skip ci] chore(stack): merge codex/260912-60plus-stream-cursor into …
lidge-jun c240534
[skip ci] chore(stack): merge codex/260912-60plus-stream-sideband int…
lidge-jun 90667e5
[skip ci] chore(stack): merge codex/260912-60plus-models-images into …
lidge-jun 00f8567
[skip ci] chore(stack): merge codex/260912-60plus-operations-pairing …
lidge-jun 8acd73b
[skip ci] chore(stack): merge codex/260912-60plus-operations-transpor…
lidge-jun 388c9d1
[skip ci] chore(stack): merge codex/260912-operations-client-probe in…
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Precise ingress degradation diagnosis | ||
|
|
||
| User intake4353 discussion3995160105. P amendment reprioritizes a source review repair before pairing; pairing source was not changed. Class C2, satisfy-spec, same tool/write bounds and no resource cap; no local suite/build/typecheck/install, no merges/services. Final behavior proof is hosted CI. | ||
|
|
||
| Valid managementIngress is currently blamed when an invalid sibling makes the whole hub parse disappear. MODIFY src/config.ts: reuse the existing private managementIngressSchema in hubConfigSchema and raw-field validation; test the raw ingress with that same strict schema before issuing its field-specific warning. Do not change normalization, acceptance, port relationship validation, or whole-hub warnings. Rawvalues never printed. | ||
|
|
||
| MODIFY tests/config/config-load-degrade.test.ts: valid ingress plus invalid dataPublicOrigin must warn about the actual hub sibling and not claim managementIngress invalid; preserve file bytes. Existing malformed-ingress cases still warn. Update020 and structure/config.md canonical wording. Independent source re-audit then authorized comment reply/resolution; hosted criterion remainsOPEN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Operations resume checkpoint | ||
|
|
||
| Update carry #4343 merged with exact candidate f37894711158fa8215d26bed642389148ac395f6 and successful Cross-platform CI34674523305. The already-carried stop fix is not replayed. Original issue/PR closure stays with integration coordination. | ||
|
|
||
| Listener #4353, usage #4357 → #4373 and pairing #4378 remain open. Published usage source/security audits passed; hosted execution must be checked on the final cumulative tip. Prior Cline registration/native-restore fixture failures are retained as failures; current dev has a separate repair, and this unit does not duplicate its ownership. | ||
|
|
||
| Pairing resumed at persisted C. The previous local compound-failure patch matched the newer remote commit byte-for-byte and was preserved before fast-forward. The subsequent fix uses an erasable explicit error field and JSX event handlers for the hosted compiler/lint failures; no checks were disabled. A hidden-document pairing fixture excludes periodic polling, and a controlled resource deadline verifies stale-data marking. Hosted execution and rendered preview remain pending. | ||
|
|
||
| The OpenCode management-token and local transport change remains outstanding against original #4317 CHANGES_REQUESTED. No whole-lane completion is claimed. All local suites, focused tests, GUI tests, build, typecheck and installs are NOT RUN. No service changes or release actions were performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Coordinator-refusal fixture diagnostics | ||
|
|
||
| The Windows5 failure in run34693005384 ended the transaction child at its existing15-second deadline before result assertions. The failed head and current dev have identical scoped test/connect/lock/ACL source. The log does not identify the stalled phase, so this work adds evidence and strengthens the coordinator-specific oracle; it does not claim to repair a proven production stall. | ||
|
|
||
| Class C2, satisfy-spec, triggered by parent triage assignment. Scope: tests/clients/client-connect.test.ts and this plan only. No runtime, ACL policy, unrelated fixture, or timeout-budget changes. Local suites/build/typecheck/install NOT RUN; manual hosted dispatch/rerun HOLD. Existing publication and independent model-inheriting source review remain authorized. Stop this diagnostic slice when source reviewed and published; actual Windows outcome remains open until authorized hosted execution. Original operations verification criteria remain unchanged/open in verification-resume after the cancelled-CI checkpoint. | ||
|
|
||
| MODIFY the existing transaction child script: synchronously emit fixed JSON phase markers on stderr around module load, connect invocation/completion, state observation and result publication. Markers contain only an allowlisted phase and bounded nonnegative integer elapsed milliseconds. They contain no home paths, URL, credentials, error text or raw output. | ||
|
|
||
| MODIFY the parent fixture: parse only those marker objects on failure before throwing ClientStateProbeError, and include only validated phase/elapsed evidence. Preserve15-second kill, successful exit requirement, output parse and all cleanup. A valid result followed by a retained child still fails. Unknown/malformed marker fields are ignored; never expose raw stderr/stdout. Existing other fixtures keep the same constructor behavior. | ||
|
|
||
| MODIFY the coordinator oracle: inspect the caught cause chain for the exact CONFIG_MUTATION_LOCK_UNAVAILABLE code and expose only a boolean in fixture JSON. Assert this in addition to connected=null, calls=[], absent token/catalog and zeroed authority. An earlier lifecycle refusal must not pass as coordinator coverage. No matching on arbitrary raw error prose. | ||
|
|
||
| Extend existing fixture self-checks with valid phase evidence on a retained child and malformed/unknown/secret-shaped marker controls. All original expectations remain. Independent A/C review checks marker privacy, actual reachability, timeout/cleanup retention and unchanged production source. git diff --check is whitespace evidence only. Hosted execution after HOLD must distinguish module loading, connect-internal delay and completed-result exit retention; until then no root-cause or baseline-green claim. | ||
|
|
||
| Design reflection accepted: cause traversal uses a seen-object set and finite depth; connect markers distinguish entered, resolved and rejected outcomes; result_published follows serialization/output. Parent scans a bounded stderr tail and accepts only fixed phase names plus finite nonnegative integer elapsed milliseconds within a fixed cap. A valid marker followed by malformed input retains the valid evidence. These markers do not identify a particular inner ACL/lock call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Run the required documentation build.
This public documentation change must pass
cd docs-site && bun install --frozen-lockfile && bun run buildbefore completion. Do not report documentation validation as passed until the command succeeds.🤖 Prompt for AI Agents
Source: Coding guidelines