fix(cline): align integration registration contracts - #4386
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 74 / 80설명 이 PR은 Cline이 열다섯 번째 export client로 들어간 뒤에도, 주변 목록이 예전 개수를 말하고 있어서 깨지는 계약을 맞춥니다. 지금 패치는 작습니다. help 문구를 15로 바꾸고, GUI 쪽 파일 통합 client 목록에 라인 - 이게 무슨 문제다
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Exact-head CI for 5990da5 completed with failure: https://github.com/luvs01/opencodex/actions/runs/34679954387 The deduplicated recorded assertion failures are five injection/journal cases tracked by #4380, three Devin path cases tracked by #4384, and two pnpm shim cases tracked by #4379. The seven inventory contracts repaired here were absent from that failure list; the complementary runs and focused tests support this classification. Correction of evidence scope: the local pnpm reproduction used another branch with an unrelated bridge patch, not a pristine dev checkout. Its pnpm files were unchanged, and Windows reported mode 666 after chmod(0755), explaining the POSIX fixture failure. That supports fixture attribution but is not a full baseline execution. The run remains red, and no claim is made that absence from assertion logs proves every job or every failure cause. Draft remains pending integration/validation. |
|
Follow-up to the inventory review: this PR is now rebased onto dev c27a483 at head 18aba46. Range-diff preserves the original patch. Typecheck, structure, privacy, and the 43 integration-invariant tests passed on this new head. The earlier broader focused results remain documented in the description; they are not a full cross-platform pass. The assertion/comment both say fifteen. I recommend keeping this small inventory repair separate and retaining the lightweight literal help count with its registry-derived assertion. The proposed three-dot PR diff preserves dev's remote test entries; a two-tip comparison includes unrelated base drift. The prior head's matrix failed on the other shared groups. The new head has not executed its upstream product matrix: Cross-platform CI 34687029104 and React Doctor 34687029091 both require maintainer approval. Could a maintainer approve those reviewed-head executions and decide the integration order for the shared baseline repairs: Cline inventories here, Devin paths in #4384, pnpm shims in #4379, and native restore fixture alignment in #4380? The authored follow-ups have been rebased and their changed-area checks pass, but each independent head still lacks the sibling fixes. A maintainer-managed integration/landing plan can break that dependency cycle without duplicating unrelated patches into every PR. The latest-dev and resolved-findings checklist items are complete. Full-CI and Ready remain unchecked until the corresponding evidence exists; no readiness override or merge approval is claimed. |
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. Hygiene✅ Deterministic PR hygiene checks passed. |
5990da5 to
18aba46
Compare
Summary
Cline is registered as the fifteenth export client, but several surrounding inventories still describe the pre-Cline set. This makes the existing help, localization, registry, asset-provenance, and test-layout checks fail after the integration lands.
Update the help count and complete the explicit client inventories. Keep the two Cline CLI product-name keys in the existing French and Traditional Chinese brand allowlists. Classify Cline client/writer test seeds as client integrations while retaining Cline provider and ClinePass tests in providers. Record the existing icon's Git provenance and normalization without inventing an unrecorded download URL.
The help count stays literal to preserve the existing lightweight help path. The existing registry-derived assertion continues to catch drift. This changes no client writer, translated copy, browser component, or icon bytes.
Earlier focused verification (before this rebase)
d42a1363dc82330c749f4ce5c5f6b3c507483159before editing: help count, registry count, test seed classification, and four dashboard contract tests.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --check: passed.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Current rebase and readiness evidence (2026-09-12)
Current head:
18aba466a1707da27394d396891e56096a4a02cb, rebased ontodev@c27a4831a9d1629005ffce626d54c7b60a00c1de. Range-diff preserves the original patch series. No unresolved review threads were found before publication. The latest-dev and resolved-findings items are checked on this evidence.Fresh verification on this head:
bun run typecheck— passed.bun run structure:check— passed.bun run privacy:scan— passed.bun test --isolate --timeout 60000 ./tests/gui/integrations-invariants.test.ts— passed.These are targeted checks, not a full CI pass. Previous hosted failures belong to the superseded head
5990da5a4fdedf27f8ee75591e511723b9d88bff. Shared CI blockers (Cline inventories, native restore fixtures, Devin/pnpm fixtures) still require integration; known single-run failures also remain unproven resolved. The CI and Ready items stay unchecked, and the PR stays Draft. This rebase does not incorporate sibling PRs or claim their fixes. The upstream synchronize event supplies the new-head CI/approval entry; no duplicate fork matrix was dispatched merely to repeat known shared failures.