docs(structure): record what clear-cooldown does to a lapsed window - #4398
Conversation
#4397 made a live avoidance window its own reason for the clear-cooldown operation to act, which changes the operator-facing contract. structure/INDEX.md maps src/codex/ to this document, so the SSOT has to say that a lapsed cooldown with a live window still reports a clear, and that an account with neither still reports no change.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe provider contract now documents that cooldown clearing also handles live avoidance windows after cooldown expiry. It defines clear and no-change results without exposing whether an account exists. ChangesOpenAI account-mode contract
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation-only change clarifies existing clear-cooldown behavior without introducing runtime or deployment risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 56 / 80이 PR은 방금 지금 범위는 문서만이다. 소스·테스트·제품 동작은 건드리지 않는다. #4396+#4397 기차가 연 쿼터 회피 탈출구를 운영자·후속 기여자가 읽을 수 있게 만드는 최소 보완이다. 라인 107 근처 새 문단 - “쿨다운이 이미 끝난 창에 대한 관리 연산”이라는 설명이 #4397의 실제 운영 장면을 바로 가리킨다. 짧은 쿨다운·긴 회피라는 설계 이유까지 한 문장에 넣어서, 왜 그 상태가 흔한지 읽힌다. 라인 109~110 - “회피만 살아 있어도 성공·클리어 보고”, “둘 다 없으면 변경 없음 → 계정 존재 여부 비공개”가 코드의 경로 structure/providers/openai-tiers.md - 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Maintainer integration decision (dev only, per MAINTAINERS.md). Exact head |
Product tree is dev at 7bfb2ad. Only package.json differs, carrying the stable channel version 2.52.0. This promotion follows a CI repair and a regression sweep: dev had drifted 79 commits past its last finished run and the one run allowed to complete had failed. lidge-jun#4390 fixed an integration test that never denied anything and had been red on dev since lidge-jun#4342; lidge-jun#4396/lidge-jun#4397/lidge-jun#4398 closed four gaps in the quota avoidance contract lidge-jun#4368 introduced; lidge-jun#4403 made a port fixture deterministic.
Summary
structure/providers/openai-tiers.mdwhat fix(codex): let clear-cooldown lift an avoidance the cooldown outlived #4397 changed about the operator-facingclear-cooldowncontract: because the cooldown is the shorter of the two durations, the state an operator usually finds is an expired cooldown with a live avoidance window, and that window alone now makes the operation succeed and report a clear. An account with neither still reports no change, which is what keeps the route from disclosing whether an account exists.Verification
structure/INDEX.mdmapssrc/codex/to this document, andbun run structure:checkruns in CI as part ofgates.Checklist
Summary by CodeRabbit