-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(usage): show the cached subset beside every token total #4421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { describe, expect, test } from "bun:test"; | ||
| import { formatTokens, formatTokensWithCache } from "../../gui/src/format-tokens"; | ||
|
|
||
| /** | ||
| * A cached request's total is mostly cache. The logs table has always shown the | ||
| * total with a stacked `c <read>`; every other surface printed the total alone, | ||
| * which reads as a different, smaller request than the rows beside it. | ||
| */ | ||
| describe("formatTokensWithCache", () => { | ||
| test("renders the cached subset beside the total in both number scales", () => { | ||
| expect(formatTokensWithCache(58_000, 57_000, "ko")).toBe("5.8만 c5.7만"); | ||
| expect(formatTokensWithCache(58_000, 57_000, "en")).toBe("58K c57K"); | ||
| expect(formatTokensWithCache(58_000, 57_000, "zh")).toBe("5.8万 c5.7万"); | ||
| }); | ||
|
|
||
| test("a provider that reports no cache is left exactly as it was", () => { | ||
| for (const cached of [undefined, 0, Number.NaN]) { | ||
| expect(formatTokensWithCache(58_000, cached, "ko")).toBe(formatTokens(58_000, "ko")); | ||
| } | ||
| // A negative count is nonsense rather than a cache miss; treat it as absent. | ||
| expect(formatTokensWithCache(58_000, -1, "en")).toBe("58K"); | ||
| }); | ||
|
|
||
| test("a turn served entirely from cache still shows the marker", () => { | ||
| // This is the most cached row on the page. Hiding the companion when the | ||
| // subset equals the total would blank exactly the case worth showing. | ||
| expect(formatTokensWithCache(57_000, 57_000, "en")).toBe("57K c57K"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When cached usage is present, the dashboard and Usage tables now display compact values such as
58K c57K, butdocs-site/src/content/docs/guides/web-dashboard.mdstill describes only a token total and the CLI observability reference does not explain thatcis a non-additive cache-read subset. Users encountering the notation outside the Logs detail view therefore have no documented way to interpret it; update the English documentation and keep the translated pages consistent.AGENTS.md reference: AGENTS.md:L380-L381
Useful? React with 👍 / 👎.