fix(xai): scope Fast-tier catalog copy to key-auth pricing (carry of #4077) - #4474
Conversation
#4431 opened Grok OAuth subscription rows to Fast. Those rows have no per-token price, so the shared catalog string advertised a 2x token price where it is false. Keep the priority-processing claim and scope the token-price claim to key auth. Residue of #4077 only. The source branch's forwardCallerServiceTier flips are not carried: live origin/dev keeps grok-4.20-multi-agent-0309 excluded after a 2026-09-13 probe recorded a default-tier downgrade. Co-authored-by: Jerome <221477575+laerad777@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe xAI Fast-tier description now states that tier pricing applies only to key authentication. A comment explains the OAuth pricing distinction. Related service and catalog tests now expect the revised description. ChangesxAI Fast-tier description
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This narrowly scoped catalog wording update is ready to merge with no identified user or production risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83be41fc00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fastTierDescription: "Priority processing, 2x token price", | ||
| // Shared across key and OAuth catalog rows. OAuth subscription has no | ||
| // per-token price, so the 2x claim is scoped to key auth. | ||
| fastTierDescription: "Priority processing; tier pricing applies on key auth only", |
There was a problem hiding this comment.
For users authenticated through ocx login xai, this catalog text now correctly says that tier pricing applies only to key auth, but docs-site/src/content/docs/reference/configuration/providers.md:443-446 still states without that qualification that xAI charges 2× and applies the premium whenever priority is echoed—which the OAuth gateway does. Update that section to scope the billing claim to API-key requests and clarify any intentionally retained API-reference estimates so OAuth subscribers are not told they incur per-token charges.
AGENTS.md reference: src/AGENTS.md:L29-L29
Useful? React with 👍 / 👎.
리뷰 · 우선순위 55 / 80설명 변경은 우선순위 55는 런타임 버그가 아니라 카탈로그 카피 정확도 문제라서다. 그래도 OAuth Fast를 켠 뒤에는 반드시 고쳐야 하는 residue다.
심볼 #4077 residue / #4431 - 본문이 말한 “세 커밋 중 Fast 카피만 남음”과 diff 범위가 일치한다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
…work lidge-jun#4077 proposed opening the Grok OAuth lane to service_tier priority and correcting the Fast-tier catalog copy. The registry half landed independently through lidge-jun#4431 with a narrower, live-probed scope and no reference to the proposal; the copy correction landed later through lidge-jun#4474 with a trailer. The first half is recorded as an acknowledgement rather than as carried code. Also records the gate's false-positive mode: a description that merely talks about a carry train fails missing_coauthor_credit even with no source author, which lidge-jun#4499 hit. Writing around it is cheaper than loosening the matcher.
1 participant
Summary
fastTierDescriptionstill advertised"Priority processing, 2x token price"where that claim is false."Priority processing; tier pricing applies on key auth only". Priority processing stays; the token-price claim is scoped to key auth. The pins that read this string moved with it:src/providers/registry.ts,tests/service/service-tier-capability.test.ts, andtests/codex-integration/codex-catalog.test.ts.docs-site/has no pin.forwardCallerServiceTierflips, includinggrok-4.20-multi-agent-0309totrue. Liveorigin/devkeeps that model excluded after the 2026-09-13 probe recorded the gateway answeringservice_tier: "default"when sent"priority". Cherry-picking fix(provider): enable service_tier priority on the xAI OAuth Responses lane #4077 would re-break that evidence-based exclusion.Co-authored-by: Jerome 221477575+laerad777@users.noreply.github.com
Verification
bun test tests/service/service-tier-capability.test.ts tests/codex-integration/codex-catalog.test.ts→ 374 pass, 0 failbun run typecheck→ exit 0rg "2x token price"is empty undersrc/,tests/,docs-site/,gui/, andstructure/grok-4.20-multi-agent-0309remains absent frommodelSupportsServiceTierand still pinsforwardCallerTier: falseChecklist
Summary by CodeRabbit