-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(devlog): record the 2.56.0 release evidence #4700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,29 @@ What the decision rests on, and what it does not: | |
| Recorded as each step completes. | ||
|
|
||
| - #4690 head `0026b14e83`, the post-fix candidate. | ||
|
|
||
| ## What actually happened | ||
|
|
||
| - Candidate: `386303af1c` on `dev` — the squash of #4690, which carried the two regression fixes. | ||
| Its pre-merge head `26b3ff244434846149b560e28f7441afae529564` passed Cross-platform CI as run | ||
| `34945255301`. | ||
|
Comment on lines
+50
to
+52
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win Clarify the candidate CI evidence. Run 🤖 Prompt for AI Agents |
||
| - `dev` moved to 2.57.0 through #4686 before any promotion, so `assert-ahead` could pass. | ||
| - `main`: #4694 merged as `e4a8539b957b7ae7cd278666f0364eb0f82d4ac3`, carrying 2.56.0. Its push | ||
| runs at that exact SHA: Cross-platform CI `34947608073` success, Service lifecycle `34947608122` | ||
| success. #4687, cut from the pre-fix `2702911708`, was closed as superseded. | ||
| - `preview`: #4698 merged as `b552b1db59`. The head was an `ours`-strategy merge, so its tree is | ||
| byte-identical to the candidate and to what `main` received; the merge exists to record the old | ||
| preview tip as a parent, which is the shape every earlier promotion onto that branch used. | ||
| - Release: `release.yml` run `34951392978`, dispatched from `main` with | ||
| `expected-sha=e4a8539b95…`, `version=2.56.0`, `tag=latest`, `dry-run=false`. Both jobs succeeded. | ||
| The publish step reported `+ @bitkyc08/opencodex@2.56.0` with a provenance statement written to | ||
| the sigstore transparency log, and tag `v2.56.0` plus the GitHub release exist. | ||
| - Registry metadata still read 2.55.0 immediately afterwards. The workflow says so itself and | ||
| instructs against republishing; a lagging read is not a failed publish. | ||
|
|
||
| ## What shipped that the audit did not clear | ||
|
|
||
| Nothing. The two regressions it found were fixed before promotion, and the fix itself went through | ||
| three review rounds: the first only released in the `catch`, the second confirmed before a rebuild | ||
| that can fail without sending, and only the third confirms at the two points that reach the wire. | ||
| The accepted risks are listed in `020_regression_audit.md` and are unchanged by this release. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This final-evidence entry identifies
26b3ff244434846149b560e28f7441afae529564as the pre-merge head of #4690, while the same document's Evidence section still identifies0026b14e83as “the post-fix candidate.” Because this record uses exact-head CI to justify the release decision, the two unqualified head values leave the candidate chronology internally inconsistent. Update the earlier bullet to the final head or explicitly mark that SHA as superseded and identify which review round it represented.Useful? React with 👍 / 👎.