Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/test-layout/layout.json
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,7 @@
"management-provider-proto-override.test.ts": "server",
"management-provider-synthetic-max.test.ts": "server",
"management-provider-validation.test.ts": "server",
"management-provider-verbosity.test.ts": "server",
"management-route-registry.test.ts": "server",
"management-workflow-budget-routes.test.ts": "server",
"memory-watchdog.test.ts": "server",
Expand Down
2 changes: 2 additions & 0 deletions src/server/auth-cors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,8 @@ export function providerManagementConfigError(
if (reasoningSummariesError) return `provider ${name} ${reasoningSummariesError}`;
const suppressSyntheticMaxError = booleanRecordConfigError(raw.modelSuppressSyntheticMax, "modelSuppressSyntheticMax");
if (suppressSyntheticMaxError) return `provider ${name} ${suppressSyntheticMaxError}`;
const verbositySupportError = booleanRecordConfigError(raw.modelSupportsVerbosity, "modelSupportsVerbosity");
if (verbositySupportError) return `provider ${name} ${verbositySupportError}`;
const reasoningSummaryDeliveryError = reasoningSummaryDeliveryRecordConfigError(
raw.modelReasoningSummaryDelivery,
raw.modelSupportsReasoningSummaries,
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/test-layout-expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,7 @@
"management-provider-proto-override.test.ts": "server",
"management-provider-synthetic-max.test.ts": "server",
"management-provider-validation.test.ts": "server",
"management-provider-verbosity.test.ts": "server",
"management-route-registry.test.ts": "server",
"management-workflow-budget-routes.test.ts": "server",
"memory-watchdog.test.ts": "server",
Expand Down
71 changes: 71 additions & 0 deletions tests/server/management-provider-verbosity.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import { expect, test } from "bun:test";
import { mkdtempSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { loadConfig, saveConfig } from "../../src/config";
import { startServer } from "../../src/server";
import { installIsolatedCodexHome } from "../helpers/isolated-codex-home";
import { managementFetch as fetch } from "../helpers/management-auth";
import { removeTreeWithRetry } from "../helpers/remove-tree";

test("provider management validates verbosity records without replacing valid config", async () => {
const testDir = mkdtempSync(join(tmpdir(), "ocx-provider-verbosity-"));
const previousHome = process.env.OPENCODEX_HOME;
const previousToken = process.env.OPENCODEX_API_AUTH_TOKEN;
const isolatedCodexHome = installIsolatedCodexHome("ocx-provider-verbosity-codex-");
process.env.OPENCODEX_HOME = testDir;
let server: ReturnType<typeof startServer> | undefined;
try {
saveConfig({
port: 0,
defaultProvider: "openai",
openaiProviderTierVersion: 2,
providers: {
openai: {
adapter: "openai-responses",
baseUrl: "https://chatgpt.com/backend-api/codex",
authMode: "forward",
codexAccountMode: "direct",
},
},
});
server = startServer(0);
const acceptedVerbosityCapability = await fetch(new URL("/api/providers", server.url), {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({
name: "custom-verbosity-capability",
provider: {
adapter: "openai-responses",
baseUrl: "https://api.example.test/v1",
modelSupportsVerbosity: { terse: false },
},
}),
});
expect(acceptedVerbosityCapability.status).toBe(200);
for (const invalid of [[], { terse: "false" }, { "": false }]) {
const rejected = await fetch(new URL("/api/providers", server.url), {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({
name: "custom-verbosity-capability",
provider: {
adapter: "openai-responses",
baseUrl: "https://api.example.test/v1",
modelSupportsVerbosity: invalid,
},
}),
});
expect(rejected.status).toBe(400);
}
expect(loadConfig().providers["custom-verbosity-capability"].modelSupportsVerbosity).toEqual({ terse: false });
} finally {
await server?.stop(true);
if (previousHome === undefined) delete process.env.OPENCODEX_HOME;
else process.env.OPENCODEX_HOME = previousHome;
if (previousToken === undefined) delete process.env.OPENCODEX_API_AUTH_TOKEN;
else process.env.OPENCODEX_API_AUTH_TOKEN = previousToken;
isolatedCodexHome.restore();
removeTreeWithRetry(testDir);
}
}, 60_000);
Loading