Fix 6 React Doctor findings and pin the CI engine to 0.9.3 - #931
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR updates React Doctor references to 0.9.3, moves OAuth generation state into its hook, lazily initializes GUI refs, and changes several component exports and icons. ChangesGUI maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3 tasks
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
Fix 6 React Doctor findings and pin the CI engine to 0.9.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCodexAccountPool, the OAuth generation map inuseProvidersOAuth,Integrationstab refs) sonew Set()/new Map()are not rebuilt and discarded on every render.IconSparkle,DataSurfaceSkeletonBlock) flagged byunused-export. Two of the six findings were already reportable by the pinned 0.9.2 engine but live in files the changed-file CI scope never scanned; the other four are new in 0.9.3.gui/README.mdand the workflow-contract tests to match.Validation
react-doctor@0.9.3 --scope full --no-telemetry— 0 diagnosticsreact-doctor@0.9.2 --scope full --no-telemetry— 0 diagnosticsbun run typecheck— passcd gui && bun run lint— passcd gui && bun test tests— 535 pass, 0 failcd gui && bun run build— passbun run privacy:scan— passbun run doctor:gui:if-changed— no issuesbun test tests/ci-workflows.test.ts— 66 pass, 0 failbun run test— 7562 pass, 14 fail; all 14 are pre-existing symlink-creation failures that reproduce identically on a clean checkout ofupstream/dev(see Limitations)Review notes
oauthLoginGenerationRefmoved intouseProvidersOAuth, its only consumer: react-doctor 0.9.3 rejects the null-guarded lazy-init pattern when the ref is passed into another hook, and eslintreact-hooks/refsrejects it when the ref arrives as a hook parameter. Owning it locally satisfies both.cancelLoginOAuthdependency array; ref identity is stable across renders, so callback recreation is unchanged.version: 0.9.2toversion: 0.9.3is the only workflow change; the action SHA pin,blocking: warning, and read-only permissions are untouched.Limitations
bun run testreports 14 failures on this Windows host:symlinkSyncthrowsEPERMbecause symlink creation needs Developer Mode/admin. The identical 14 tests fail on a clean checkout ofupstream/devwithout this PR.Summary by CodeRabbit