-
Notifications
You must be signed in to change notification settings - Fork 556
feat(codex): add account-qualified catalog entries #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chrisae9
wants to merge
12
commits into
lidge-jun:dev
Choose a base branch
from
chrisae9:split/426-03-account-catalog
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,271
−344
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
021300b
feat(codex): add account-qualified catalog entries
chrisae9 55c4cc1
fix(codex): harden account catalog projection
chrisae9 f11a3d1
fix(codex): address account catalog edge cases
chrisae9 aa60d7f
fix(codex): address account catalog review
chrisae9 c2a5a93
fix(codex): address account catalog follow-up
chrisae9 cc0d817
docs(codex): clarify projected prompt model
chrisae9 2915b4b
docs(codex): document account selector picker rows
chrisae9 49091da
docs(codex): clarify selector dashboard boundaries
chrisae9 4655943
fix(codex): avoid ambiguous prompt model ids
chrisae9 9d1ad9d
test(codex): stabilize catalog integration checks
chrisae9 79df008
fix(codex): preserve case-distinct account fallbacks
chrisae9 acb5ad8
docs(codex): document account selector precedence
chrisae9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With account-qualified picker ids now documented here, the separate Model Routing guide still describes
provider/modelas the first routing rule and never mentions<selector>/<native-openai-model>(checkeddocs-site/src/content/docs/guides/model-routing.mdlines 14-48). In configs with a selector,router.tsresolves that selector before provider namespaces and sends the bare native id to the mapped account, so users following the routing guide can reason about the wrong precedence; update that guide and its translations alongside this picker change.AGENTS.md reference: docs-site/AGENTS.md:L7-L10
Useful? React with 👍 / 👎.